Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer CMAKE_CURRENT_SOURCE_DIR over CMAKE_SOURCE_DIR for the project's source directory #856

Merged
merged 1 commit into from
Jul 22, 2023
Merged

Prefer CMAKE_CURRENT_SOURCE_DIR over CMAKE_SOURCE_DIR for the project's source directory #856

merged 1 commit into from
Jul 22, 2023

Conversation

Rbot427
Copy link
Contributor

@Rbot427 Rbot427 commented Jul 14, 2023

  1. Switch from CMAKE_SOURCE_DIR to CMAKE_CURRENT_SOURCE_DIR when specifying the imgui config path and openvr library. This makes it so others can build REF as an embedded dependency via cmake's add_subdirectory
  2. Fix the build errors in the example plugin

@praydog praydog merged commit 87b3d6d into praydog:master Jul 22, 2023
dtlnor pushed a commit to dtlnor/REFramework that referenced this pull request Sep 12, 2024
@Rbot427 @dtlnor
tighten scope of cmake current directory (praydog#856)
21cc528
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rbot427 @praydog