Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pre-commit-2332 #1089

Closed
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 41 additions & 6 deletions pre_commit_hooks/check_json.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import argparse
import json
import re
from typing import Any
from typing import Sequence

Expand All @@ -18,19 +19,53 @@ def raise_duplicate_keys(
return d


def check_mixed_indentation(content: str, filename: str) -> bool:
"""
Checks a string content for mixed indentation (tabs and spaces) in leading whitespace.

Args:
content (str): The content of the file to check.
filename (str): The name of the file being checked (for reporting purposes).

Returns:
bool: True if mixed indentation is found, False otherwise.
"""
found_mixed = False

for i, line in enumerate(content.splitlines(), 1):
# Determine leading whitespace
leading_whitespace = line[:len(line) - len(line.lstrip())]

# Check if both tabs and spaces are present in leading whitespace
if ' ' in leading_whitespace and '\t' in leading_whitespace:
print(f"{filename}: Mixed indentation (tabs and spaces) found on line {i}")
found_mixed = True

return not found_mixed


def main(argv: Sequence[str] | None = None) -> int:
parser = argparse.ArgumentParser()
parser.add_argument('filenames', nargs='*', help='Filenames to check.')
args = parser.parse_args(argv)

retval = 0
for filename in args.filenames:
with open(filename, 'rb') as f:
try:
json.load(f, object_pairs_hook=raise_duplicate_keys)
except ValueError as exc:
print(f'{filename}: Failed to json decode ({exc})')
retval = 1
with open(filename) as f:
content = f.read()

# Check for mixed indentation first
if not check_mixed_indentation(content, filename):
retval = 1
continue

# Then, attempt to parse the JSON
try:
json.loads(content, object_pairs_hook=raise_duplicate_keys)
except ValueError as exc:
print(f'{filename}: Failed to json decode ({exc})')
retval = 1

return retval


Expand Down
Loading