Attempt to add fixing of BOMs #522
Conversation
jgowdy
force-pushed
the
byte-order-marker-fix
branch
from
3de1539
to
5a7ca4e
Compare
|
Sorry for the churn, I don't write much Python |
jgowdy
force-pushed
the
byte-order-marker-fix
branch
5 times, most recently
from
c8ef07f
to
f3cee4e
Compare
|
Okay, I think this is good now. |
|
Would you mind adding a hacktoberfest-accepted label to this PR? I didn't make this change specifically for hacktoberfest, I need it, but I am participating in hacktoberfest. Thanks! |
|
yeah sorry I've been slow about this -- I'll take a look when I get the chance 👍 |
asottile
force-pushed
the
byte-order-marker-fix
branch
from
f3cee4e
to
d18bd5b
Compare
| @@ -17,8 +17,8 @@ | |||
| language: python | |||
| types: [python] | |||
| - id: check-byte-order-marker | |||
| name: Check for byte-order marker | |||
| description: Forbid files which have a UTF-8 byte-order marker | |||
| name: 'check BOM - deprecated: use fix-byte-order-marker' | |||
There was a problem hiding this comment.
I shortened the name here so it doesn't wrap -- I should probably add a test for this
| @@ -131,6 +131,12 @@ | |||
| entry: file-contents-sorter | |||
| language: python | |||
| files: '^$' | |||
| - id: fix-byte-order-marker | |||
There was a problem hiding this comment.
I renamed this to fix-byte-order-marker so it's more clear what it does
|
|
||
| def main(argv: Optional[Sequence[str]] = None) -> int: | ||
| parser = argparse.ArgumentParser() | ||
| parser.add_argument('filenames', nargs='*', help='Filenames to check') |
There was a problem hiding this comment.
I removed the --fix=no -- I'd rather have formatters-only
|
|
||
| for filename in args.filenames: | ||
| with open(filename, 'rb') as f_b: | ||
| bts = f_b.read(3) |
There was a problem hiding this comment.
there was a leaking file descriptor here, I fixed that
I'm attempting to add automatic fixing of BOMs