Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check_executables_have_shebangs: avoid unneeded shebang reads on win32 #544

Merged
merged 1 commit into from
Jan 8, 2021
Merged

check_executables_have_shebangs: avoid unneeded shebang reads on win32 #544

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions pre_commit_hooks/check_executables_have_shebangs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,7 @@ def _check_git_filemode(paths: Sequence[str]) -> int:
tagmode = metadata.split(' ', 1)[0]

is_executable = any(b in EXECUTABLE_VALUES for b in tagmode[-3:])
has_shebang = _check_has_shebang(path)
if is_executable and not has_shebang:
if is_executable and not _check_has_shebang(path):
_message(path)
seen.add(path)

Expand Down