Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check also directories in check_case_conflict #575

Merged
merged 1 commit into from
Apr 4, 2021
Merged

check also directories in check_case_conflict #575

merged 1 commit into from
Apr 4, 2021

Conversation

slsyy
Copy link
Contributor

@slsyy slsyy commented Mar 19, 2021

fix #70

asottile
asottile reviewed Mar 19, 2021
View reviewed changes
pre_commit_hooks/check_case_conflict.py Outdated Show resolved Hide resolved
pre_commit_hooks/check_case_conflict.py Outdated Show resolved Hide resolved
pre_commit_hooks/check_case_conflict.py Outdated Show resolved Hide resolved
pre_commit_hooks/check_case_conflict.py Outdated Show resolved Hide resolved
tests/check_case_conflict_test.py Show resolved Hide resolved
@slsyy slsyy force-pushed the master branch 2 times, most recently from e567150 to fd797fa Compare March 19, 2021 19:36
@slsyy
Copy link
Contributor Author

slsyy commented Mar 21, 2021

@asottile please re-review

asottile
asottile reviewed Mar 26, 2021
View reviewed changes
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just a few small things -- sorry for the delay I've been very busy

pre_commit_hooks/check_case_conflict.py Outdated Show resolved Hide resolved
pre_commit_hooks/check_case_conflict.py Outdated Show resolved Hide resolved
asottile
asottile approved these changes Apr 4, 2021
View reviewed changes
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile asottile merged commit ae47531 into pre-commit:master Apr 4, 2021
@guykisel guykisel mentioned this pull request Jul 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asottile asottile asottile approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

check-case-conflict doesn't notice directory name conflicts
2 participants
@slsyy @asottile