-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify rdbms backends #54
Conversation
This is breaking on Travis, not (for once) through my fault, but because M::Plugin::OpenAPI has broken us again. See jhthorsen/mojolicious-plugin-openapi#107 for more. |
ec06531
to
c5d52c7
Compare
(You can see for yourself by trying locally with M::P::OAPI 2.09 (should work), 2.10 (should fail)) |
While we wait for the fix to be merged, @preaction are there any issues with this PR that I can look at fixing concurrently? :-) |
No issues, nope. Though I think in the long run we'll end up making that role into two base classes (one for all backends that handles constructor (not connection) and dealing with JSON schema lookups and one for the Mojo::* backends that has all those methods in them). Thanks! |
Intended to help implement relations between collections. The common code, using at least the DBI method
foreign_key_info
forread_schema
, will be able to go in the various roles.The unifying has also had a slight tidying effect, e.g. the Pg code wasn't doing
normalize
.