Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify rdbms backends #54

Merged
merged 21 commits into from
Feb 7, 2019
Merged

Conversation

mohawk2
Copy link
Contributor

@mohawk2 mohawk2 commented Feb 1, 2019

Intended to help implement relations between collections. The common code, using at least the DBI method foreign_key_info for read_schema, will be able to go in the various roles.

The unifying has also had a slight tidying effect, e.g. the Pg code wasn't doing normalize.

@mohawk2
Copy link
Contributor Author

mohawk2 commented Feb 1, 2019

This is breaking on Travis, not (for once) through my fault, but because M::Plugin::OpenAPI has broken us again. See jhthorsen/mojolicious-plugin-openapi#107 for more.

@mohawk2
Copy link
Contributor Author

mohawk2 commented Feb 1, 2019

(You can see for yourself by trying locally with M::P::OAPI 2.09 (should work), 2.10 (should fail))

@mohawk2
Copy link
Contributor Author

mohawk2 commented Feb 5, 2019

While we wait for the fix to be merged, @preaction are there any issues with this PR that I can look at fixing concurrently? :-)

@preaction
Copy link
Owner

No issues, nope. Though I think in the long run we'll end up making that role into two base classes (one for all backends that handles constructor (not connection) and dealing with JSON schema lookups and one for the Mojo::* backends that has all those methods in them).

Thanks!

@preaction preaction merged commit 6cd489a into preaction:master Feb 7, 2019
@mohawk2 mohawk2 deleted the unify-rdbms-backends branch February 7, 2019 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants