Merge pull request #4051 from ottomao/master

preactjs · Jun 25, 2023 · a5c810c · a5c810c
2 parents 0ef740b + a12d60e
commit a5c810c
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 5 deletions.
diff --git a/test-utils/src/index.js b/test-utils/src/index.js
@@ -32,11 +32,19 @@ export function act(cb) {
 		// been set up.
 		//
 		// If an exception occurs, the outermost `act` will handle cleanup.
-		const result = cb();
-		if (isThenable(result)) {
-			return result.then(() => {
-				--actDepth;
-			});
+		try {
+			const result = cb();
+			if (isThenable(result)) {
+				return result.then(() => {
+					--actDepth;
+				}, (e) => {
+					--actDepth;
+					throw e;
+				})
+			}
+		} catch(e) {
+			--actDepth;
+			throw e;
 		}
 		--actDepth;
 		return Promise.resolve();

diff --git a/test-utils/test/shared/act.test.js b/test-utils/test/shared/act.test.js
@@ -385,6 +385,12 @@ describe('act', () => {
 			} catch (e) {}
 		};
 
+		const tryNestedRenderBroken = () => {
+			act(() => {
+				tryRenderBroken();
+			});
+		}
+
 		describe('synchronously', () => {
 			it('should rethrow the exception', () => {
 				expect(renderBroken).to.throw('BrokenWidget is broken');
@@ -396,6 +402,12 @@ describe('act', () => {
 				expect(scratch.textContent).to.equal('1');
 			});
 
+			it('should not affect state updates in future renders when nested `act` throws an exception', () => {
+				tryNestedRenderBroken();
+				renderWorking();
+				expect(scratch.textContent).to.equal('1');
+			});
+
 			it('should not affect effects in future renders', () => {
 				tryRenderBroken();
 				renderWorking();