replace isConnected with parentDom.contains (#4421)

* replace isConnected with parentDom.contains * add contains
preactjs · Jun 25, 2024 · eb37677 · eb37677
1 parent 92e86e9
commit eb37677
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/compat/src/portals.js b/compat/src/portals.js
@@ -39,6 +39,7 @@ function Portal(props) {
 			nodeType: 1,
 			parentNode: container,
 			childNodes: [],
+			contains: () => true,
 			appendChild(child) {
 				this.childNodes.push(child);
 				_this._container.appendChild(child);

diff --git a/src/diff/children.js b/src/diff/children.js
@@ -117,7 +117,7 @@ export function diffChildren(
 			oldVNode._children === childVNode._children
 		) {
 			// @ts-expect-error olDom should be present on a DOM node
-			if (oldDom && !oldDom.isConnected) {
+			if (oldDom && !parentDom.contains(oldDom)) {
 				oldDom = getDomSibling(oldVNode);
 			}
 			oldDom = insert(childVNode, oldDom, parentDom);