Prepare test code to be run in ES2015+ environments #2901

marvinhagemeister · 2021-01-02T20:07:56Z

Today I played around a bit with running our test suite in native ES2015+ environments. That is to say that I skipped the transpilation step to ES5. By doing so I noticed that the prototype of a native class is not iterable. So calling Object.keys(MyClass.prototype) will always return an empty array. This breaks some of our tests.

Since we don't iterate over prototypes that often I just inlined our helper functions.

This is caused by the class properties not being marked as iterable. They are typically downtranspiled to plain objects, which why calling Object.keys(MyClass) worked before

github-actions · 2021-01-02T20:08:19Z

📊 Tachometer Benchmark Results

Summary

duration

02_replace1k: unsure 🔍 -2% - +1% (-3.15ms - +1.93ms)
^{preact-local vs preact-master}
03_update10th1k_x16: faster ✔ 1% - 7% (0.44ms - 2.70ms)
^{preact-local vs preact-master}
07_create10k: unsure 🔍 -0% - +1% (-1.74ms - +24.59ms)
^{preact-local vs preact-master}
filter_list: unsure 🔍 -1% - +5% (-0.37ms - +1.57ms)
^{preact-local vs preact-master}
hydrate1k: unsure 🔍 -2% - +2% (-3.31ms - +3.18ms)
^{preact-local vs preact-master}
many_updates: unsure 🔍 -5% - +9% (-1.92ms - +3.63ms)
^{preact-local vs preact-master}
text_update: unsure 🔍 -4% - +2% (-0.17ms - +0.07ms)
^{preact-local vs preact-master}

usedJSHeapSize

02_replace1k: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
^{preact-local vs preact-master}
03_update10th1k_x16: unsure 🔍 -0% - -0% (-0.01ms - -0.00ms)
^{preact-local vs preact-master}
07_create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
^{preact-local vs preact-master}
filter_list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
^{preact-local vs preact-master}
hydrate1k: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
^{preact-local vs preact-master}
many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
^{preact-local vs preact-master}
text_update: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
^{preact-local vs preact-master}

Results

02_replace1k

Browser: chrome-headless 87.0.4280.88
Sample size: 80
Built by: CI #653
Commit: bf6b04a

duration

Version	Avg time	vs preact-master	vs preact-local
preact-master	160.40ms - 163.99ms	-	unsure 🔍 -1% - +2% -1.93ms - +3.15ms
preact-local	159.80ms - 163.38ms	unsure 🔍 -2% - +1% -3.15ms - +1.93ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local
preact-master	3.60ms - 3.61ms	-	unsure 🔍 -0% - +0% -0.01ms - +0.01ms
preact-local	3.60ms - 3.61ms	unsure 🔍 -0% - +0% -0.01ms - +0.01ms	-

run-warmup-0

Version	Avg time	vs preact-master	vs preact-local
preact-master	62.07ms - 64.06ms	-	unsure 🔍 -3% - +1% -1.95ms - +0.78ms
preact-local	62.72ms - 64.59ms	unsure 🔍 -1% - +3% -0.78ms - +1.95ms	-

run-warmup-1

Version	Avg time	vs preact-master	vs preact-local
preact-master	95.39ms - 97.92ms	-	unsure 🔍 -2% - +2% -1.69ms - +1.60ms
preact-local	95.64ms - 97.75ms	unsure 🔍 -2% - +2% -1.60ms - +1.69ms	-

run-warmup-2

Version	Avg time	vs preact-master	vs preact-local
preact-master	110.64ms - 113.47ms	-	unsure 🔍 -1% - +3% -0.76ms - +3.20ms
preact-local	109.46ms - 112.22ms	unsure 🔍 -3% - +1% -3.20ms - +0.76ms	-

run-warmup-3

Version	Avg time	vs preact-master	vs preact-local
preact-master	64.38ms - 66.73ms	-	unsure 🔍 -2% - +3% -1.53ms - +1.79ms
preact-local	64.25ms - 66.60ms	unsure 🔍 -3% - +2% -1.79ms - +1.53ms	-

run-warmup-4

Version	Avg time	vs preact-master	vs preact-local
preact-master	116.85ms - 122.14ms	-	unsure 🔍 -5% - +1% -6.02ms - +1.72ms
preact-local	118.82ms - 124.47ms	unsure 🔍 -1% - +5% -1.72ms - +6.02ms	-

run-final

Version	Avg time	vs preact-master	vs preact-local
preact-master	65.33ms - 67.30ms	-	unsure 🔍 -1% - +4% -0.47ms - +2.38ms
preact-local	64.33ms - 66.38ms	unsure 🔍 -4% - +1% -2.38ms - +0.47ms	-

03_update10th1k_x16

Browser: chrome-headless 87.0.4280.88
Sample size: 120
Built by: CI #653
Commit: bf6b04a

duration

Version	Avg time	vs preact-master	vs preact-local
preact-master	35.16ms - 36.92ms	-	slower ❌ 1% - 8% 0.44ms - 2.70ms
preact-local	33.76ms - 35.19ms	faster ✔ 1% - 7% 0.44ms - 2.70ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local
preact-master	3.52ms - 3.53ms	-	unsure 🔍 +0% - +0% +0.00ms - +0.01ms
preact-local	3.51ms - 3.52ms	unsure 🔍 -0% - -0% -0.01ms - -0.00ms	-

07_create10k

Browser: chrome-headless 87.0.4280.88
Sample size: 50
Built by: CI #653
Commit: bf6b04a

duration

Version	Avg time	vs preact-master	vs preact-local
preact-master	1960.30ms - 1975.56ms	-	unsure 🔍 -1% - +0% -24.59ms - +1.74ms
preact-local	1968.62ms - 1990.08ms	unsure 🔍 -0% - +1% -1.74ms - +24.59ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local
preact-master	25.99ms - 25.99ms	-	unsure 🔍 -0% - +0% -0.00ms - +0.00ms
preact-local	25.99ms - 25.99ms	unsure 🔍 -0% - +0% -0.00ms - +0.00ms	-

filter_list

Browser: chrome-headless 87.0.4280.88
Sample size: 50
Built by: CI #653
Commit: bf6b04a

duration

Version	Avg time	vs preact-master	vs preact-local
preact-master	31.09ms - 32.33ms	-	unsure 🔍 -5% - +1% -1.57ms - +0.37ms
preact-local	31.56ms - 33.05ms	unsure 🔍 -1% - +5% -0.37ms - +1.57ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local
preact-master	1.60ms - 1.60ms	-	unsure 🔍 -0% - +0% -0.00ms - +0.00ms
preact-local	1.60ms - 1.60ms	unsure 🔍 -0% - +0% -0.00ms - +0.00ms	-

hydrate1k

Browser: chrome-headless 87.0.4280.88
Sample size: 50
Built by: CI #653
Commit: bf6b04a

duration

Version	Avg time	vs preact-master	vs preact-local
preact-master	180.69ms - 185.18ms	-	unsure 🔍 -2% - +2% -3.18ms - +3.31ms
preact-local	180.53ms - 185.22ms	unsure 🔍 -2% - +2% -3.31ms - +3.18ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local
preact-master	6.19ms - 6.19ms	-	unsure 🔍 -0% - +0% -0.01ms - +0.00ms
preact-local	6.19ms - 6.21ms	unsure 🔍 -0% - +0% -0.00ms - +0.01ms	-

many_updates

Browser: chrome-headless 87.0.4280.88
Sample size: 80
Built by: CI #653
Commit: bf6b04a

duration

Version	Avg time	vs preact-master	vs preact-local
preact-master	38.02ms - 41.96ms	-	unsure 🔍 -9% - +5% -3.63ms - +1.92ms
preact-local	38.89ms - 42.80ms	unsure 🔍 -5% - +9% -1.92ms - +3.63ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local
preact-master	4.85ms - 4.85ms	-	unsure 🔍 -0% - +0% -0.00ms - +0.00ms
preact-local	4.85ms - 4.85ms	unsure 🔍 -0% - +0% -0.00ms - +0.00ms	-

text_update

Browser: chrome-headless 87.0.4280.88
Sample size: 160
Built by: CI #653
Commit: bf6b04a

duration

Version	Avg time	vs preact-master	vs preact-local
preact-master	3.75ms - 3.96ms	-	unsure 🔍 -2% - +4% -0.07ms - +0.17ms
preact-local	3.75ms - 3.87ms	unsure 🔍 -4% - +2% -0.17ms - +0.07ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local
preact-master	0.83ms - 0.83ms	-	unsure 🔍 -0% - +0% -0.00ms - +0.00ms
preact-local	0.83ms - 0.83ms	unsure 🔍 -0% - +0% -0.00ms - +0.00ms	-

_{tachometer-reporter-action v2 for CI}

coveralls · 2021-01-02T20:10:15Z

Coverage remained the same at 99.609% when pulling 90bfb18 on test-fixes into 51b46f6 on master.

github-actions · 2021-01-02T20:11:06Z

Size Change: 0 B

Total Size: 41.6 kB

ℹ️ View Unchanged

Filename	Size	Change
`compat/dist/compat.js`	3.23 kB	0 B
`compat/dist/compat.module.js`	3.25 kB	0 B
`compat/dist/compat.umd.js`	3.29 kB	0 B
`debug/dist/debug.js`	2.99 kB	0 B
`debug/dist/debug.module.js`	2.98 kB	0 B
`debug/dist/debug.umd.js`	3.07 kB	0 B
`devtools/dist/devtools.js`	185 B	0 B
`devtools/dist/devtools.module.js`	195 B	0 B
`devtools/dist/devtools.umd.js`	261 B	0 B
`dist/preact.js`	4.03 kB	0 B
`dist/preact.min.js`	4.06 kB	0 B
`dist/preact.module.js`	4.05 kB	0 B
`dist/preact.umd.js`	4.1 kB	0 B
`hooks/dist/hooks.js`	1.13 kB	0 B
`hooks/dist/hooks.module.js`	1.15 kB	0 B
`hooks/dist/hooks.umd.js`	1.2 kB	0 B
`jsx-runtime/dist/jsxRuntime.js`	327 B	0 B
`jsx-runtime/dist/jsxRuntime.module.js`	335 B	0 B
`jsx-runtime/dist/jsxRuntime.umd.js`	405 B	0 B
`test-utils/dist/testUtils.js`	437 B	0 B
`test-utils/dist/testUtils.module.js`	439 B	0 B
`test-utils/dist/testUtils.umd.js`	515 B	0 B

_{compressed-size-action}

andrewiggins · 2021-01-02T22:09:08Z

Oooo running our tests using modern syntax would be really nice

Fix unable to run tests in native ES2015+ envs

b50b921

This is caused by the class properties not being marked as iterable. They are typically downtranspiled to plain objects, which why calling Object.keys(MyClass) worked before

Merge branch 'master' into test-fixes

90bfb18

andrewiggins approved these changes Jan 2, 2021

View reviewed changes

marvinhagemeister merged commit 6ea2d55 into master Jan 2, 2021

marvinhagemeister deleted the test-fixes branch January 2, 2021 22:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prepare test code to be run in ES2015+ environments #2901

Prepare test code to be run in ES2015+ environments #2901

marvinhagemeister commented Jan 2, 2021

github-actions bot commented Jan 2, 2021 •

edited

Loading

📊 Tachometer Benchmark Results

Summary

duration

usedJSHeapSize

Results

duration

usedJSHeapSize

run-warmup-0

run-warmup-1

run-warmup-2

run-warmup-3

run-warmup-4

run-final

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

coveralls commented Jan 2, 2021 •

edited

Loading

github-actions bot commented Jan 2, 2021 •

edited

Loading

andrewiggins commented Jan 2, 2021

Prepare test code to be run in ES2015+ environments #2901

Prepare test code to be run in ES2015+ environments #2901

Conversation

marvinhagemeister commented Jan 2, 2021

github-actions bot commented Jan 2, 2021 • edited Loading

📊 Tachometer Benchmark Results

Summary

duration

usedJSHeapSize

Results

duration

usedJSHeapSize

run-warmup-0

run-warmup-1

run-warmup-2

run-warmup-3

run-warmup-4

run-final

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

coveralls commented Jan 2, 2021 • edited Loading

github-actions bot commented Jan 2, 2021 • edited Loading

andrewiggins commented Jan 2, 2021

github-actions bot commented Jan 2, 2021 •

edited

Loading

coveralls commented Jan 2, 2021 •

edited

Loading

github-actions bot commented Jan 2, 2021 •

edited

Loading