-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Karma replace webpack with esbuild + babel #2907
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Tachometer Benchmark ResultsSummarydurationResults⏱ 02_replace1k03_update10th1k_x16duration
usedJSHeapSize
⏱ 07_create10k⏱ filter_listduration
usedJSHeapSize
⏱ hydrate1k⏱ many_updates⏱ text_updateduration
usedJSHeapSize
|
Size Change: 0 B Total Size: 41.7 kB ℹ️ View Unchanged
|
The benchmarks fail because we exceeded the free tier minutes. |
JoviDeCroock
approved these changes
Jan 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow! Nice work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR swaps out
webpack
withesbuild
as our bundler of choice. I've triedrollup
too in #2894 but that leads to out of heap space errors (tries to allocate more than 2GB). As expected,esbuild
takes the lead by taking up only a fraction of RAM compared to the competition. That holds true, despite the comparably slow babel pass in place. Without that esbuild compiles and bunldes our whole suite in just ~500ms.With
esbuild
we enjoy a similarly readable output like we would have withrollup
. So we get the same benefits as in #2894, just a lot faster and with a fraction of the RAM cost.Before:
After: