Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix karma benchmarks not compiling #2914

Merged
merged 2 commits into from
Jan 5, 2021
Merged

Fix karma benchmarks not compiling #2914

merged 2 commits into from
Jan 5, 2021

Conversation

marvinhagemeister
Copy link
Member

@andrewiggins Found a bug in karma-esbuild and this upgrades it to the version with the fix.

@github-actions
Copy link

github-actions bot commented Jan 5, 2021 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -2% - +2% (-3.86ms - +2.87ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -8% - +1% (-2.88ms - +0.23ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -1% - +1% (-12.48ms - +12.14ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -1% - +2% (-0.25ms - +0.39ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -1% - +1% (-1.02ms - +0.98ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -7% - +4% (-2.77ms - +1.55ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -1% - +2% (-0.05ms - +0.07ms)
    preact-local vs preact-master

usedJSHeapSize

  • 02_replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master

Results

02_replace1k
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 80
  • Built by: CI #682

  • Commit: 331a6ef

duration

VersionAvg timevs preact-mastervs preact-local
preact-master170.80ms - 175.59ms-unsure 🔍
-2% - +2%
-2.87ms - +3.86ms
preact-local170.34ms - 175.06msunsure 🔍
-2% - +2%
-3.86ms - +2.87ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.60ms - 3.61ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-local3.60ms - 3.61msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms		-

run-warmup-0

VersionAvg timevs preact-mastervs preact-local
preact-master66.24ms - 68.17ms-unsure 🔍
-1% - +2%
-0.95ms - +1.63ms
preact-local66.01ms - 67.72msunsure 🔍
-2% - +1%
-1.63ms - +0.95ms		-

run-warmup-1

VersionAvg timevs preact-mastervs preact-local
preact-master101.61ms - 103.80ms-unsure 🔍
-1% - +2%
-1.23ms - +1.83ms
preact-local101.34ms - 103.48msunsure 🔍
-2% - +1%
-1.83ms - +1.23ms		-

run-warmup-2

VersionAvg timevs preact-mastervs preact-local
preact-master115.50ms - 119.66ms-unsure 🔍
-2% - +2%
-2.92ms - +2.55ms
preact-local115.99ms - 119.53msunsure 🔍
-2% - +2%
-2.55ms - +2.92ms		-

run-warmup-3

VersionAvg timevs preact-mastervs preact-local
preact-master63.21ms - 67.99ms-unsure 🔍
-2% - +6%
-1.30ms - +4.08ms
preact-local62.98ms - 65.45msunsure 🔍
-6% - +2%
-4.08ms - +1.30ms		-

run-warmup-4

VersionAvg timevs preact-mastervs preact-local
preact-master119.37ms - 126.08ms-unsure 🔍
-4% - +3%
-4.94ms - +4.16ms
preact-local120.04ms - 126.19msunsure 🔍
-3% - +4%
-4.16ms - +4.94ms		-

run-final

VersionAvg timevs preact-mastervs preact-local
preact-master63.51ms - 65.78ms-unsure 🔍
-2% - +3%
-0.97ms - +1.92ms
preact-local63.27ms - 65.07msunsure 🔍
-3% - +1%
-1.92ms - +0.97ms		-
03_update10th1k_x16
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 120
  • Built by: CI #682

  • Commit: 331a6ef

duration

VersionAvg timevs preact-mastervs preact-local
preact-master35.29ms - 37.66ms-unsure 🔍
-1% - +8%
-0.23ms - +2.88ms
preact-local34.15ms - 36.16msunsure 🔍
-8% - +1%
-2.88ms - +0.23ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.52ms - 3.53ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-local3.52ms - 3.52msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms		-
07_create10k
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 50
  • Built by: CI #682

  • Commit: 331a6ef

duration

VersionAvg timevs preact-mastervs preact-local
preact-master1720.71ms - 1735.06ms-unsure 🔍
-1% - +1%
-12.14ms - +12.48ms
preact-local1717.71ms - 1737.72msunsure 🔍
-1% - +1%
-12.48ms - +12.14ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master25.99ms - 25.99ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local25.99ms - 25.99msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
filter_list
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 50
  • Built by: CI #682

  • Commit: 331a6ef

duration

VersionAvg timevs preact-mastervs preact-local
preact-master24.10ms - 24.56ms-unsure 🔍
-2% - +1%
-0.39ms - +0.25ms
preact-local24.18ms - 24.62msunsure 🔍
-1% - +2%
-0.25ms - +0.39ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master1.60ms - 1.60ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local1.60ms - 1.60msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
hydrate1k
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 50
  • Built by: CI #682

  • Commit: 331a6ef

duration

VersionAvg timevs preact-mastervs preact-local
preact-master141.92ms - 143.63ms-unsure 🔍
-1% - +1%
-0.98ms - +1.02ms
preact-local142.24ms - 143.27msunsure 🔍
-1% - +1%
-1.02ms - +0.98ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master6.19ms - 6.21ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-local6.19ms - 6.20msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms		-
many_updates
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 80
  • Built by: CI #682

  • Commit: 331a6ef

duration

VersionAvg timevs preact-mastervs preact-local
preact-master39.17ms - 42.41ms-unsure 🔍
-4% - +7%
-1.55ms - +2.77ms
preact-local38.75ms - 41.61msunsure 🔍
-7% - +4%
-2.77ms - +1.55ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master4.85ms - 4.85ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local4.85ms - 4.85msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
text_update
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 50
  • Built by: CI #682

  • Commit: 331a6ef

duration

VersionAvg timevs preact-mastervs preact-local
preact-master3.46ms - 3.53ms-unsure 🔍
-2% - +1%
-0.07ms - +0.05ms
preact-local3.46ms - 3.55msunsure 🔍
-1% - +2%
-0.05ms - +0.07ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master0.83ms - 0.83ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local0.83ms - 0.83msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-

tachometer-reporter-action v2 for CI

andrewiggins
andrewiggins approved these changes Jan 5, 2021
View reviewed changes
Copy link
Member

@andrewiggins andrewiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@coveralls
Copy link

coveralls commented Jan 5, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 99.618% when pulling e37411c on karma-bench into 989315c on master.

@github-actions
Copy link

github-actions bot commented Jan 5, 2021

Size Change: 0 B

Total Size: 42 kB

ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.37 kB 0 B
compat/dist/compat.module.js 3.37 kB 0 B
compat/dist/compat.umd.js 3.42 kB 0 B
debug/dist/debug.js 2.99 kB 0 B
debug/dist/debug.module.js 2.98 kB 0 B
debug/dist/debug.umd.js 3.07 kB 0 B
devtools/dist/devtools.js 185 B 0 B
devtools/dist/devtools.module.js 195 B 0 B
devtools/dist/devtools.umd.js 261 B 0 B
dist/preact.js 4.04 kB 0 B
dist/preact.min.js 4.07 kB 0 B
dist/preact.module.js 4.06 kB 0 B
dist/preact.umd.js 4.11 kB 0 B
hooks/dist/hooks.js 1.13 kB 0 B
hooks/dist/hooks.module.js 1.15 kB 0 B
hooks/dist/hooks.umd.js 1.2 kB 0 B
jsx-runtime/dist/jsxRuntime.js 327 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 335 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 405 B 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.module.js 439 B 0 B
test-utils/dist/testUtils.umd.js 515 B 0 B

compressed-size-action

@marvinhagemeister marvinhagemeister merged commit bd3c655 into master Jan 5, 2021
@marvinhagemeister marvinhagemeister deleted the karma-bench branch January 5, 2021 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewiggins andrewiggins andrewiggins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marvinhagemeister @coveralls @andrewiggins