Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests in IE11 #2924

Merged
merged 6 commits into from
Jan 12, 2021
Merged

Fix tests in IE11 #2924

merged 6 commits into from
Jan 12, 2021

Conversation

marvinhagemeister
Copy link
Member

This PR makes all tests pass on IE11 again. Check out the commit messages for a detailed description of the changes.

@github-actions
Copy link

github-actions bot commented Jan 12, 2021 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -2% - +1% (-3.18ms - +2.38ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -5% - +5% (-1.59ms - +1.65ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +1% (-5.21ms - +10.86ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -3% - +4% (-0.70ms - +1.17ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -2% - +1% (-2.29ms - +1.27ms)
    preact-local vs preact-master
  • many_updates: faster ✔ 1% - 14% (0.22ms - 5.42ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -1% - +0% (-0.04ms - +0.00ms)
    preact-local vs preact-master

usedJSHeapSize

  • 02_replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -0% - +0% (-0.02ms - +0.03ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master

Results

02_replace1k
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 70
  • Built by: CI #702

  • Commit: 0f40fd2

duration

VersionAvg timevs preact-mastervs preact-local
preact-master198.33ms - 201.97ms-unsure 🔍
-1% - +2%
-2.38ms - +3.18ms
preact-local197.65ms - 201.85msunsure 🔍
-2% - +1%
-3.18ms - +2.38ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.60ms - 3.60ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-local3.60ms - 3.60msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms		-

run-warmup-0

VersionAvg timevs preact-mastervs preact-local
preact-master71.18ms - 73.00ms-unsure 🔍
-2% - +2%
-1.14ms - +1.30ms
preact-local71.20ms - 72.82msunsure 🔍
-2% - +2%
-1.30ms - +1.14ms		-

run-warmup-1

VersionAvg timevs preact-mastervs preact-local
preact-master115.02ms - 116.74ms-unsure 🔍
-2% - +0%
-2.77ms - +0.27ms
preact-local115.88ms - 118.38msunsure 🔍
-0% - +2%
-0.27ms - +2.77ms		-

run-warmup-2

VersionAvg timevs preact-mastervs preact-local
preact-master129.90ms - 133.28ms-unsure 🔍
-2% - +1%
-3.01ms - +0.93ms
preact-local131.62ms - 133.64msunsure 🔍
-1% - +2%
-0.93ms - +3.01ms		-

run-warmup-3

VersionAvg timevs preact-mastervs preact-local
preact-master75.17ms - 77.41ms-unsure 🔍
-3% - +1%
-2.19ms - +0.85ms
preact-local75.93ms - 77.98msunsure 🔍
-1% - +3%
-0.85ms - +2.19ms		-

run-warmup-4

VersionAvg timevs preact-mastervs preact-local
preact-master140.87ms - 146.06ms-unsure 🔍
-0% - +6%
-0.58ms - +7.93ms
preact-local136.41ms - 143.16msunsure 🔍
-6% - +0%
-7.93ms - +0.58ms		-

run-final

VersionAvg timevs preact-mastervs preact-local
preact-master74.65ms - 76.26ms-unsure 🔍
-2% - +2%
-1.26ms - +1.16ms
preact-local74.60ms - 76.42msunsure 🔍
-2% - +2%
-1.16ms - +1.26ms		-
03_update10th1k_x16
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 60
  • Built by: CI #702

  • Commit: 0f40fd2

duration

VersionAvg timevs preact-mastervs preact-local
preact-master31.91ms - 34.38ms-unsure 🔍
-5% - +5%
-1.65ms - +1.59ms
preact-local32.13ms - 34.23msunsure 🔍
-5% - +5%
-1.59ms - +1.65ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.52ms - 3.53ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-local3.52ms - 3.53msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms		-
07_create10k
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 50
  • Built by: CI #702

  • Commit: 0f40fd2

duration

VersionAvg timevs preact-mastervs preact-local
preact-master1486.01ms - 1498.02ms-unsure 🔍
-1% - +0%
-10.86ms - +5.21ms
preact-local1489.50ms - 1500.18msunsure 🔍
-0% - +1%
-5.21ms - +10.86ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master25.99ms - 25.99ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local25.99ms - 25.99msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
filter_list
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 50
  • Built by: CI #702

  • Commit: 0f40fd2

duration

VersionAvg timevs preact-mastervs preact-local
preact-master25.81ms - 26.98ms-unsure 🔍
-4% - +3%
-1.17ms - +0.70ms
preact-local25.90ms - 27.36msunsure 🔍
-3% - +4%
-0.70ms - +1.17ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master1.60ms - 1.60ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local1.60ms - 1.60msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
hydrate1k
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 50
  • Built by: CI #702

  • Commit: 0f40fd2

duration

VersionAvg timevs preact-mastervs preact-local
preact-master133.57ms - 136.03ms-unsure 🔍
-1% - +2%
-1.27ms - +2.29ms
preact-local133.00ms - 135.57msunsure 🔍
-2% - +1%
-2.29ms - +1.27ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master6.19ms - 6.22ms-unsure 🔍
-0% - +0%
-0.03ms - +0.02ms
preact-local6.19ms - 6.23msunsure 🔍
-0% - +0%
-0.02ms - +0.03ms		-
many_updates
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 80
  • Built by: CI #702

  • Commit: 0f40fd2

duration

VersionAvg timevs preact-mastervs preact-local
preact-master35.17ms - 39.23ms-slower ❌
0% - 16%
0.22ms - 5.42ms
preact-local32.76ms - 36.00msfaster ✔
1% - 14%
0.22ms - 5.42ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master4.85ms - 4.85ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local4.85ms - 4.85msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
text_update
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 50
  • Built by: CI #702

  • Commit: 0f40fd2

duration

VersionAvg timevs preact-mastervs preact-local
preact-master3.05ms - 3.08ms-unsure 🔍
-0% - +1%
-0.00ms - +0.04ms
preact-local3.03ms - 3.06msunsure 🔍
-1% - +0%
-0.04ms - +0.00ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master0.83ms - 0.83ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local0.83ms - 0.83msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-

tachometer-reporter-action v2 for CI

@coveralls
Copy link

coveralls commented Jan 12, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.8%) to 99.615% when pulling 32289b0 on ie-11-tests into 12d8182 on master.

@github-actions
Copy link

github-actions bot commented Jan 12, 2021 •
edited
Loading

Size Change: 0 B

Total Size: 42 kB

ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.34 kB 0 B
compat/dist/compat.module.js 3.33 kB 0 B
compat/dist/compat.umd.js 3.39 kB 0 B
debug/dist/debug.js 2.99 kB 0 B
debug/dist/debug.module.js 2.98 kB 0 B
debug/dist/debug.umd.js 3.07 kB 0 B
devtools/dist/devtools.js 185 B 0 B
devtools/dist/devtools.module.js 195 B 0 B
devtools/dist/devtools.umd.js 261 B 0 B
dist/preact.js 4.04 kB 0 B
dist/preact.min.js 4.07 kB 0 B
dist/preact.module.js 4.06 kB 0 B
dist/preact.umd.js 4.11 kB 0 B
hooks/dist/hooks.js 1.13 kB 0 B
hooks/dist/hooks.module.js 1.15 kB 0 B
hooks/dist/hooks.umd.js 1.2 kB 0 B
jsx-runtime/dist/jsxRuntime.js 327 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 335 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 405 B 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.module.js 439 B 0 B
test-utils/dist/testUtils.umd.js 515 B 0 B

compressed-size-action

@marvinhagemeister
Remove faulty Symbol polyfill in IE11
4322eed 
We need to ensure that Preact works out of the box in IE11
@marvinhagemeister
Fix preventDefault() test failing in IE11
ce2640f 
For some reason preventDefault() _must_ be called from within the event
handler. Calling it outside of it does nothing
@marvinhagemeister
Fix hydrate test in IE11 caused by attribute sort order
9d70869
@marvinhagemeister
Don't spy on node.attributes in iE11
daa035f 
Messing with internal prototypes doesn't work in IE11
@marvinhagemeister
Adapt assertion for IE11 always serializing input value
77eca53
@marvinhagemeister
Ignore defaultValue test in IE11 for now
32289b0
@marvinhagemeister marvinhagemeister merged commit 1347e83 into master Jan 12, 2021
@marvinhagemeister marvinhagemeister deleted the ie-11-tests branch January 12, 2021 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marvinhagemeister @coveralls @JoviDeCroock