Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify unmount logic #3120

Merged
merged 1 commit into from
Apr 20, 2021
Merged

Simplify unmount logic #3120

merged 1 commit into from
Apr 20, 2021

Conversation

andrewiggins
Copy link
Member

Simplify unmounting logic to save some bytes. Should offset the bytes from #3115.

@github-actions
Copy link

github-actions bot commented Apr 20, 2021 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -1% - +2% (-1.94ms - +3.64ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: faster ✔ 1% - 8% (0.40ms - 3.43ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +1% (-4.08ms - +18.96ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -2% - +4% (-0.66ms - +1.20ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -2% - +3% (-3.18ms - +5.70ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -8% - +6% (-3.38ms - +2.53ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -1% - +1% (-0.03ms - +0.05ms)
    preact-local vs preact-master

usedJSHeapSize

  • 02_replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-master

Results

02_replace1k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master189.47ms - 193.26ms-unsure 🔍
-2% - +1%
-3.64ms - +1.94ms
preact-local190.17ms - 194.26msunsure 🔍
-1% - +2%
-1.94ms - +3.64ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.57ms - 3.58ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-local3.57ms - 3.58msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms		-

run-warmup-0

VersionAvg timevs preact-mastervs preact-local
preact-master71.78ms - 72.97ms-unsure 🔍
-1% - +1%
-0.77ms - +0.85ms
preact-local71.79ms - 72.89msunsure 🔍
-1% - +1%
-0.85ms - +0.77ms		-

run-warmup-1

VersionAvg timevs preact-mastervs preact-local
preact-master109.70ms - 111.88ms-unsure 🔍
-2% - +1%
-1.75ms - +1.08ms
preact-local110.22ms - 112.04msunsure 🔍
-1% - +2%
-1.08ms - +1.75ms		-

run-warmup-2

VersionAvg timevs preact-mastervs preact-local
preact-master115.53ms - 124.45ms-unsure 🔍
-6% - +4%
-7.14ms - +5.14ms
preact-local116.77ms - 125.21msunsure 🔍
-4% - +6%
-5.14ms - +7.14ms		-

run-warmup-3

VersionAvg timevs preact-mastervs preact-local
preact-master71.86ms - 78.54ms-unsure 🔍
-5% - +7%
-3.78ms - +5.45ms
preact-local71.19ms - 77.55msunsure 🔍
-7% - +5%
-5.45ms - +3.78ms		-

run-warmup-4

VersionAvg timevs preact-mastervs preact-local
preact-master120.33ms - 127.55ms-unsure 🔍
-5% - +4%
-6.36ms - +4.45ms
preact-local120.86ms - 128.92msunsure 🔍
-4% - +5%
-4.45ms - +6.36ms		-

run-final

VersionAvg timevs preact-mastervs preact-local
preact-master69.49ms - 72.18ms-unsure 🔍
-2% - +3%
-1.33ms - +2.30ms
preact-local69.13ms - 71.57msunsure 🔍
-3% - +2%
-2.30ms - +1.33ms		-
03_update10th1k_x16

duration

VersionAvg timevs preact-mastervs preact-local
preact-master40.83ms - 43.20ms-slower ❌
1% - 9%
0.40ms - 3.43ms
preact-local39.16ms - 41.04msfaster ✔
1% - 8%
0.40ms - 3.43ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.65ms - 3.66ms-unsure 🔍
-0% - +0%
-0.01ms - +0.01ms
preact-local3.65ms - 3.66msunsure 🔍
-0% - +0%
-0.01ms - +0.01ms		-
07_create10k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master2041.15ms - 2056.75ms-unsure 🔍
-1% - +0%
-18.96ms - +4.08ms
preact-local2047.91ms - 2064.87msunsure 🔍
-0% - +1%
-4.08ms - +18.96ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master25.97ms - 25.97ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local25.97ms - 25.97msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
filter_list

duration

VersionAvg timevs preact-mastervs preact-local
preact-master29.31ms - 30.35ms-unsure 🔍
-4% - +2%
-1.20ms - +0.66ms
preact-local29.33ms - 30.87msunsure 🔍
-2% - +4%
-0.66ms - +1.20ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master1.58ms - 1.58ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-local1.58ms - 1.59msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms		-
hydrate1k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master162.92ms - 168.80ms-unsure 🔍
-3% - +2%
-5.70ms - +3.18ms
preact-local163.79ms - 170.45msunsure 🔍
-2% - +3%
-3.18ms - +5.70ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master6.17ms - 6.17ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local6.17ms - 6.17msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
many_updates

duration

VersionAvg timevs preact-mastervs preact-local
preact-master40.77ms - 45.05ms-unsure 🔍
-6% - +8%
-2.53ms - +3.38ms
preact-local40.45ms - 44.52msunsure 🔍
-8% - +6%
-3.38ms - +2.53ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master4.83ms - 4.83ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local4.83ms - 4.83msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
text_update

duration

VersionAvg timevs preact-mastervs preact-local
preact-master3.39ms - 3.46ms-unsure 🔍
-1% - +1%
-0.05ms - +0.03ms
preact-local3.41ms - 3.45msunsure 🔍
-1% - +1%
-0.03ms - +0.05ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master0.98ms - 0.98ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-local0.98ms - 0.98msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-

tachometer-reporter-action v2 for Benchmarks

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.446% when pulling 1f8d6ad on simplify-dom-remove into 4cdcc88 on master.

@github-actions
Copy link

Size Change: -31 B (0%)

Total Size: 42.4 kB

Filename Size Change
dist/preact.js 3.97 kB -8 B (0%)
dist/preact.min.js 4.01 kB -8 B (0%)
dist/preact.module.js 4 kB -10 B (0%)
dist/preact.umd.js 4.05 kB -5 B (0%)
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.51 kB 0 B
compat/dist/compat.module.js 3.52 kB 0 B
compat/dist/compat.umd.js 3.56 kB 0 B
debug/dist/debug.js 2.99 kB 0 B
debug/dist/debug.module.js 2.98 kB 0 B
debug/dist/debug.umd.js 3.07 kB 0 B
devtools/dist/devtools.js 232 B 0 B
devtools/dist/devtools.module.js 241 B 0 B
devtools/dist/devtools.umd.js 308 B 0 B
hooks/dist/hooks.js 1.13 kB 0 B
hooks/dist/hooks.module.js 1.15 kB 0 B
hooks/dist/hooks.umd.js 1.2 kB 0 B
jsx-runtime/dist/jsxRuntime.js 327 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 335 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 405 B 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.module.js 439 B 0 B
test-utils/dist/testUtils.umd.js 515 B 0 B

compressed-size-action

marvinhagemeister
marvinhagemeister approved these changes Apr 20, 2021
View reviewed changes
Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat, that looks way cleaner 👍

@marvinhagemeister marvinhagemeister merged commit ec88035 into master Apr 20, 2021
@marvinhagemeister marvinhagemeister deleted the simplify-dom-remove branch April 20, 2021 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewiggins @coveralls @marvinhagemeister