Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[compat] Skip rendering <noscript> contents on the client #3238

Merged
merged 3 commits into from
Oct 12, 2021

Conversation

developit
Copy link
Member

This fixes the issue from #2797, and this issue using Next.js's <Image> component with Preact.

This fixes the issue from #2797, and [this issue](https://zenn.dev/d_suke/scraps/f7013c4554ac43) using Next.js's `<Image>` component with Preact.
@github-actions
Copy link

github-actions bot commented Jul 30, 2021

Size Change: +67 B (0%)

Total Size: 42 kB

Filename Size Change
compat/dist/compat.js 3.44 kB +22 B (0%)
compat/dist/compat.module.js 3.42 kB +21 B (0%)
compat/dist/compat.umd.js 3.49 kB +24 B (0%)
ℹ️ View Unchanged
Filename Size Change
debug/dist/debug.js 2.99 kB 0 B
debug/dist/debug.module.js 2.98 kB 0 B
debug/dist/debug.umd.js 3.07 kB 0 B
devtools/dist/devtools.js 232 B 0 B
devtools/dist/devtools.module.js 241 B 0 B
devtools/dist/devtools.umd.js 308 B 0 B
dist/preact.js 3.96 kB 0 B
dist/preact.min.js 3.98 kB 0 B
dist/preact.module.js 3.98 kB 0 B
dist/preact.umd.js 4.03 kB 0 B
hooks/dist/hooks.js 1.13 kB 0 B
hooks/dist/hooks.module.js 1.14 kB 0 B
hooks/dist/hooks.umd.js 1.2 kB 0 B
jsx-runtime/dist/jsxRuntime.js 317 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 327 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 395 B 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.module.js 439 B 0 B
test-utils/dist/testUtils.umd.js 515 B 0 B

compressed-size-action

@coveralls
Copy link

coveralls commented Jul 30, 2021

Coverage Status

Coverage increased (+0.0007%) to 99.624% when pulling 211c933 on compat-skip-noscript into 6d0f682 on master.

@marvinhagemeister
Copy link
Member

Let's add a test for this 👍

@developit
Copy link
Member Author

I also want to find a way to remove the IS_DOM boolean. It should be possible to get that information from which Preact hook is called.

@marvinhagemeister
Copy link
Member

I also want to find a way to remove the IS_DOM boolean. It should be possible to get that information from which Preact hook is called.

Random idea: Maybe we could use an options property for that? Something like !options._server that we could minify on the client and only set in preact-render-to-string

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants