Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onBeforeInput attribute to type definitions #3256

Merged
merged 1 commit into from
Sep 2, 2021

Conversation

boarwell
Copy link
Contributor

Hi, Preact team.

I'm excited to read the slide about the future of Preact (especially about the removal of deopts). I'm really looking forward to the release. Thank you for all your continuous efforts!

This PR adds typedefs for onBeforeInput and onBeforeInputCapture. There are a few other changes, but they are due to prettier on the pre-commit hook.


Before:
image

After:
image

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.622% when pulling 061ffa9 on boarwell:type-beforeinput into 38819b7 on preactjs:master.

Copy link
Member

@rschristian rschristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rschristian rschristian merged commit 3980f81 into preactjs:master Sep 2, 2021
@boarwell boarwell deleted the type-beforeinput branch September 7, 2021 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants