Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add focusin/focusout to type definitions #3257

Merged
merged 1 commit into from
Sep 7, 2021
Merged

Add focusin/focusout to type definitions #3257

merged 1 commit into from
Sep 7, 2021

Conversation

boarwell
Copy link
Contributor

@boarwell boarwell commented Sep 7, 2021 •
edited
Loading

Resolves #3186.
Added onfocusin/onfocusout attributes, all lowercased according to the comments on #1611.

Before:
image

After:
image

@boarwell boarwell marked this pull request as ready for review September 7, 2021 18:16
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.622% when pulling 9d761c5 on boarwell:types-focusin-out into 3980f81 on preactjs:master.

rschristian
rschristian approved these changes Sep 7, 2021
View reviewed changes
Copy link
Member

@rschristian rschristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for adding these!

@rschristian rschristian merged commit ebd87f3 into preactjs:master Sep 7, 2021
@boarwell boarwell deleted the types-focusin-out branch September 8, 2021 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rschristian rschristian rschristian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add onfocusin/onfocusout to jsx.d.ts
3 participants
@boarwell @coveralls @rschristian