Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Remove distance limit from keyed matching #3376

Closed
wants to merge 1 commit into from

Conversation

developit
Copy link
Member

This may fix #2783.

@github-actions
Copy link

github-actions bot commented Dec 15, 2021

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -3% - +1% (-3.09ms - +0.71ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -6% - +2% (-2.11ms - +0.63ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -1% - +1% (-9.35ms - +6.74ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -1% - +2% (-0.21ms - +0.51ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -4% - +8% (-8.04ms - +16.37ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -6% - +6% (-1.84ms - +1.84ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -4% - +4% (-0.15ms - +0.14ms)
    preact-local vs preact-master

usedJSHeapSize

  • 02_replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -0% - +1% (-0.01ms - +0.08ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-master

Results

02_replace1k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master116.29ms - 119.05ms-unsure 🔍
-1% - +3%
-0.71ms - +3.09ms
preact-local115.17ms - 117.79msunsure 🔍
-3% - +1%
-3.09ms - +0.71ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.47ms - 3.49ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-local3.48ms - 3.49msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms
-

run-warmup-0

VersionAvg timevs preact-mastervs preact-local
preact-master44.42ms - 45.16ms-unsure 🔍
-1% - +1%
-0.42ms - +0.56ms
preact-local44.40ms - 45.04msunsure 🔍
-1% - +1%
-0.56ms - +0.42ms
-

run-warmup-1

VersionAvg timevs preact-mastervs preact-local
preact-master65.21ms - 66.78ms-unsure 🔍
-2% - +1%
-1.49ms - +0.40ms
preact-local66.02ms - 67.07msunsure 🔍
-1% - +2%
-0.40ms - +1.49ms
-

run-warmup-2

VersionAvg timevs preact-mastervs preact-local
preact-master57.00ms - 63.46ms-unsure 🔍
-10% - +4%
-6.30ms - +2.69ms
preact-local58.91ms - 65.15msunsure 🔍
-5% - +11%
-2.69ms - +6.30ms
-

run-warmup-3

VersionAvg timevs preact-mastervs preact-local
preact-master44.76ms - 51.45ms-unsure 🔍
-5% - +15%
-2.37ms - +6.89ms
preact-local42.65ms - 49.04msunsure 🔍
-14% - +5%
-6.89ms - +2.37ms
-

run-warmup-4

VersionAvg timevs preact-mastervs preact-local
preact-master63.40ms - 66.14ms-unsure 🔍
-3% - +3%
-1.82ms - +1.83ms
preact-local63.55ms - 65.98msunsure 🔍
-3% - +3%
-1.83ms - +1.82ms
-

run-final

VersionAvg timevs preact-mastervs preact-local
preact-master37.75ms - 40.10ms-unsure 🔍
-3% - +6%
-1.10ms - +2.16ms
preact-local37.27ms - 39.52msunsure 🔍
-6% - +3%
-2.16ms - +1.10ms
-
03_update10th1k_x16

duration

VersionAvg timevs preact-mastervs preact-local
preact-master35.43ms - 37.42ms-unsure 🔍
-2% - +6%
-0.63ms - +2.11ms
preact-local34.74ms - 36.63msunsure 🔍
-6% - +2%
-2.11ms - +0.63ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.40ms - 3.40ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-local3.40ms - 3.40msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms
-
07_create10k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master1262.73ms - 1273.59ms-unsure 🔍
-1% - +1%
-6.74ms - +9.35ms
preact-local1260.91ms - 1272.79msunsure 🔍
-1% - +1%
-9.35ms - +6.74ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master25.32ms - 25.33ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local25.32ms - 25.33msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
filter_list

duration

VersionAvg timevs preact-mastervs preact-local
preact-master23.26ms - 23.73ms-unsure 🔍
-2% - +1%
-0.51ms - +0.21ms
preact-local23.37ms - 23.92msunsure 🔍
-1% - +2%
-0.21ms - +0.51ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master1.54ms - 1.54ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local1.54ms - 1.54msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
hydrate1k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master201.41ms - 218.33ms-unsure 🔍
-8% - +4%
-16.37ms - +8.04ms
preact-local205.24ms - 222.83msunsure 🔍
-4% - +8%
-8.04ms - +16.37ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master6.13ms - 6.19ms-unsure 🔍
-1% - +0%
-0.08ms - +0.01ms
preact-local6.16ms - 6.22msunsure 🔍
-0% - +1%
-0.01ms - +0.08ms
-
many_updates

duration

VersionAvg timevs preact-mastervs preact-local
preact-master28.80ms - 31.45ms-unsure 🔍
-6% - +6%
-1.84ms - +1.84ms
preact-local28.85ms - 31.40msunsure 🔍
-6% - +6%
-1.84ms - +1.84ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master4.61ms - 4.61ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local4.61ms - 4.61msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
text_update

duration

VersionAvg timevs preact-mastervs preact-local
preact-master3.68ms - 3.90ms-unsure 🔍
-4% - +4%
-0.14ms - +0.15ms
preact-local3.69ms - 3.88msunsure 🔍
-4% - +4%
-0.15ms - +0.14ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master0.78ms - 0.78ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-local0.78ms - 0.78msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms
-

tachometer-reporter-action v2 for Benchmarks

@github-actions
Copy link

Size Change: +23 B (0%)

Total Size: 42.3 kB

Filename Size Change
dist/preact.js 3.98 kB +8 B (0%)
dist/preact.min.js 4 kB +5 B (0%)
dist/preact.module.js 4 kB +6 B (0%)
dist/preact.umd.js 4.04 kB +4 B (0%)
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.46 kB 0 B
compat/dist/compat.module.js 3.44 kB 0 B
compat/dist/compat.umd.js 3.51 kB 0 B
debug/dist/debug.js 2.99 kB 0 B
debug/dist/debug.module.js 2.98 kB 0 B
debug/dist/debug.umd.js 3.07 kB 0 B
devtools/dist/devtools.js 232 B 0 B
devtools/dist/devtools.module.js 240 B 0 B
devtools/dist/devtools.umd.js 308 B 0 B
hooks/dist/hooks.js 1.17 kB 0 B
hooks/dist/hooks.module.js 1.18 kB 0 B
hooks/dist/hooks.umd.js 1.24 kB 0 B
jsx-runtime/dist/jsxRuntime.js 317 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 327 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 395 B 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.module.js 439 B 0 B
test-utils/dist/testUtils.umd.js 515 B 0 B

compressed-size-action

@developit
Copy link
Member Author

This confirms that we won't be fixing this in the 10.x codebase, as a proper fix requires two-pass child reconciliation, which is in 11.

@developit developit closed this Dec 15, 2021
@JoviDeCroock JoviDeCroock deleted the fix-keyed-matching-10-wip branch December 15, 2021 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary unmounting/mounting children with keys
1 participant