Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back IE11 select fix #3450

Merged
merged 1 commit into from
Feb 13, 2022
Merged

Add back IE11 select fix #3450

merged 1 commit into from
Feb 13, 2022

Conversation

marvinhagemeister
Copy link
Member

@developit Turns out that line in 09c3006 was a necessary fix for IE11 after all! It's necessary to get <select>-elements to behave properly in IE11 🙈

@github-actions
Copy link

github-actions bot commented Feb 13, 2022

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -2% - +1% (-3.42ms - +1.65ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -5% - +5% (-1.45ms - +1.43ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -1% - +1% (-21.51ms - +9.27ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -0% - +5% (-0.12ms - +1.54ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -3% - +6% (-7.59ms - +12.66ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -3% - +5% (-0.79ms - +1.32ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -4% - +1% (-0.11ms - +0.04ms)
    preact-local vs preact-master

usedJSHeapSize

  • 02_replace1k: unsure 🔍 -1% - +0% (-0.04ms - +0.01ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -0% - +1% (-0.00ms - +0.04ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -1% - +2% (-0.02ms - +0.03ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -0% - +1% (-0.01ms - +0.03ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -1% - +0% (-0.04ms - +0.01ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-master

Results

02_replace1k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master144.45ms - 147.96ms-unsure 🔍
-1% - +2%
-1.65ms - +3.42ms
preact-local143.49ms - 147.15msunsure 🔍
-2% - +1%
-3.42ms - +1.65ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.58ms - 3.61ms-unsure 🔍
-0% - +1%
-0.01ms - +0.04ms
preact-local3.56ms - 3.59msunsure 🔍
-1% - +0%
-0.04ms - +0.01ms
-

run-warmup-0

VersionAvg timevs preact-mastervs preact-local
preact-master53.50ms - 54.73ms-unsure 🔍
-3% - +0%
-1.93ms - +0.04ms
preact-local54.29ms - 55.83msunsure 🔍
-0% - +4%
-0.04ms - +1.93ms
-

run-warmup-1

VersionAvg timevs preact-mastervs preact-local
preact-master78.52ms - 81.15ms-unsure 🔍
-2% - +3%
-1.81ms - +2.27ms
preact-local78.04ms - 81.16msunsure 🔍
-3% - +2%
-2.27ms - +1.81ms
-

run-warmup-2

VersionAvg timevs preact-mastervs preact-local
preact-master61.76ms - 68.83ms-unsure 🔍
-11% - +5%
-7.25ms - +3.14ms
preact-local63.54ms - 71.15msunsure 🔍
-5% - +11%
-3.14ms - +7.25ms
-

run-warmup-3

VersionAvg timevs preact-mastervs preact-local
preact-master58.49ms - 65.18ms-unsure 🔍
-6% - +10%
-3.57ms - +6.13ms
preact-local57.03ms - 64.07msunsure 🔍
-10% - +6%
-6.13ms - +3.57ms
-

run-warmup-4

VersionAvg timevs preact-mastervs preact-local
preact-master75.87ms - 80.19ms-unsure 🔍
-1% - +6%
-1.10ms - +4.44ms
preact-local74.63ms - 78.08msunsure 🔍
-6% - +1%
-4.44ms - +1.10ms
-

run-final

VersionAvg timevs preact-mastervs preact-local
preact-master47.98ms - 50.92ms-unsure 🔍
-3% - +6%
-1.24ms - +2.90ms
preact-local47.16ms - 50.07msunsure 🔍
-6% - +2%
-2.90ms - +1.24ms
-
03_update10th1k_x16

duration

VersionAvg timevs preact-mastervs preact-local
preact-master30.12ms - 32.40ms-unsure 🔍
-5% - +5%
-1.43ms - +1.45ms
preact-local30.37ms - 32.14msunsure 🔍
-5% - +5%
-1.45ms - +1.43ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.42ms - 3.45ms-unsure 🔍
-1% - +0%
-0.04ms - +0.00ms
preact-local3.44ms - 3.47msunsure 🔍
-0% - +1%
-0.00ms - +0.04ms
-
07_create10k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master1480.58ms - 1504.82ms-unsure 🔍
-1% - +1%
-9.27ms - +21.51ms
preact-local1477.11ms - 1496.06msunsure 🔍
-1% - +1%
-21.51ms - +9.27ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master25.36ms - 25.36ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local25.36ms - 25.36msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
filter_list

duration

VersionAvg timevs preact-mastervs preact-local
preact-master31.14ms - 32.10ms-unsure 🔍
-5% - +0%
-1.54ms - +0.12ms
preact-local31.65ms - 33.01msunsure 🔍
-0% - +5%
-0.12ms - +1.54ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master1.60ms - 1.64ms-unsure 🔍
-2% - +1%
-0.03ms - +0.02ms
preact-local1.60ms - 1.64msunsure 🔍
-1% - +2%
-0.02ms - +0.03ms
-
hydrate1k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master220.86ms - 236.02ms-unsure 🔍
-5% - +3%
-12.66ms - +7.59ms
preact-local224.26ms - 237.69msunsure 🔍
-3% - +6%
-7.59ms - +12.66ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master6.24ms - 6.27ms-unsure 🔍
-1% - +0%
-0.03ms - +0.01ms
preact-local6.25ms - 6.28msunsure 🔍
-0% - +1%
-0.01ms - +0.03ms
-
many_updates

duration

VersionAvg timevs preact-mastervs preact-local
preact-master25.96ms - 27.49ms-unsure 🔍
-5% - +3%
-1.32ms - +0.79ms
preact-local26.27ms - 27.71msunsure 🔍
-3% - +5%
-0.79ms - +1.32ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master4.66ms - 4.70ms-unsure 🔍
-0% - +1%
-0.01ms - +0.04ms
preact-local4.65ms - 4.68msunsure 🔍
-1% - +0%
-0.04ms - +0.01ms
-
text_update

duration

VersionAvg timevs preact-mastervs preact-local
preact-master2.86ms - 3.00ms-unsure 🔍
-2% - +4%
-0.04ms - +0.11ms
preact-local2.87ms - 2.93msunsure 🔍
-4% - +1%
-0.11ms - +0.04ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master0.82ms - 0.82ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-local0.82ms - 0.82msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms
-

tachometer-reporter-action v2 for Benchmarks

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.626% when pulling 5cc270a on ie11-select into d6c9eaa on master.

@github-actions
Copy link

Size Change: +29 B (0%)

Total Size: 42.2 kB

Filename Size Change
dist/preact.js 3.97 kB +6 B (0%)
dist/preact.min.js 4 kB +8 B (0%)
dist/preact.module.js 3.99 kB +7 B (0%)
dist/preact.umd.js 4.04 kB +8 B (0%)
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.46 kB 0 B
compat/dist/compat.module.js 3.45 kB 0 B
compat/dist/compat.umd.js 3.51 kB 0 B
debug/dist/debug.js 2.99 kB 0 B
debug/dist/debug.module.js 2.98 kB 0 B
debug/dist/debug.umd.js 3.07 kB 0 B
devtools/dist/devtools.js 232 B 0 B
devtools/dist/devtools.module.js 240 B 0 B
devtools/dist/devtools.umd.js 308 B 0 B
hooks/dist/hooks.js 1.15 kB 0 B
hooks/dist/hooks.module.js 1.17 kB 0 B
hooks/dist/hooks.umd.js 1.23 kB 0 B
jsx-runtime/dist/jsxRuntime.js 317 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 327 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 395 B 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.module.js 439 B 0 B
test-utils/dist/testUtils.umd.js 515 B 0 B

compressed-size-action

@marvinhagemeister marvinhagemeister merged commit 25cca32 into master Feb 13, 2022
@marvinhagemeister marvinhagemeister deleted the ie11-select branch February 13, 2022 23:12
@developit
Copy link
Member

At least we can drop this in 11!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants