Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix size CI failing on node version missmatch #3563

Merged
merged 1 commit into from
Jun 13, 2022
Merged

Fix size CI failing on node version missmatch #3563

merged 1 commit into from
Jun 13, 2022

Conversation

JoviDeCroock
Copy link
Member

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.444% when pulling 6173d97 on JoviDeCroock-patch-1 into 2834d5a on master.

@JoviDeCroock JoviDeCroock mentioned this pull request Jun 13, 2022
Merged
marvinhagemeister
marvinhagemeister approved these changes Jun 13, 2022
View reviewed changes
Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be totally fine going straight to 16.x as that's the latest LTS 👍

@JoviDeCroock JoviDeCroock merged commit 0b9a927 into master Jun 13, 2022
@JoviDeCroock JoviDeCroock deleted the JoviDeCroock-patch-1 branch June 13, 2022 08:16
@JoviDeCroock JoviDeCroock mentioned this pull request Jun 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@andrewiggins andrewiggins Awaiting requested review from andrewiggins

@developit developit Awaiting requested review from developit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoviDeCroock @coveralls @marvinhagemeister