Switch all ESM dist to .mjs
#3634
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,61 +5,61 @@ | |
| "private": false, | ||
| "description": "Fast 3kb React-compatible Virtual DOM library.", | ||
| "main": "dist/preact.js", | ||
| "module": "dist/preact.module.mjs", | ||
|
There was a problem hiding this comment. This isn't safe to change outside of a semver major. A lot of tools/versions of tools can consume A few months ago While I doubt Metro would be an issue for us, that just goes to show that support is not as widespread as we may hope. Node isn't going to consume |
||
| "umd:main": "dist/preact.umd.js", | ||
| "unpkg": "dist/preact.min.js", | ||
| "source": "src/index.js", | ||
| "exports": { | ||
| ".": { | ||
| "types": "./src/index.d.ts", | ||
| "browser": "./dist/preact.module.mjs", | ||
| "umd": "./dist/preact.umd.js", | ||
| "import": "./dist/preact.mjs", | ||
| "require": "./dist/preact.js" | ||
| }, | ||
| "./compat": { | ||
| "types": "./compat/src/index.d.ts", | ||
| "browser": "./compat/dist/compat.module.mjs", | ||
| "umd": "./compat/dist/compat.umd.js", | ||
| "import": "./compat/dist/compat.mjs", | ||
| "require": "./compat/dist/compat.js" | ||
| }, | ||
| "./debug": { | ||
| "browser": "./debug/dist/debug.module.mjs", | ||
| "umd": "./debug/dist/debug.umd.js", | ||
| "import": "./debug/dist/debug.mjs", | ||
| "require": "./debug/dist/debug.js" | ||
| }, | ||
| "./devtools": { | ||
| "types": "./devtools/src/index.d.ts", | ||
| "browser": "./devtools/dist/devtools.module.mjs", | ||
| "umd": "./devtools/dist/devtools.umd.js", | ||
| "import": "./devtools/dist/devtools.mjs", | ||
| "require": "./devtools/dist/devtools.js" | ||
| }, | ||
| "./hooks": { | ||
| "types": "./hooks/src/index.d.ts", | ||
| "browser": "./hooks/dist/hooks.module.mjs", | ||
| "umd": "./hooks/dist/hooks.umd.js", | ||
| "import": "./hooks/dist/hooks.mjs", | ||
| "require": "./hooks/dist/hooks.js" | ||
| }, | ||
| "./test-utils": { | ||
| "types": "./test-utils/src/index.d.ts", | ||
| "browser": "./test-utils/dist/testUtils.module.mjs", | ||
| "umd": "./test-utils/dist/testUtils.umd.js", | ||
| "import": "./test-utils/dist/testUtils.mjs", | ||
| "require": "./test-utils/dist/testUtils.js" | ||
| }, | ||
| "./jsx-runtime": { | ||
| "types": "./jsx-runtime/src/index.d.ts", | ||
| "browser": "./jsx-runtime/dist/jsxRuntime.module.mjs", | ||
| "umd": "./jsx-runtime/dist/jsxRuntime.umd.js", | ||
| "import": "./jsx-runtime/dist/jsxRuntime.mjs", | ||
| "require": "./jsx-runtime/dist/jsxRuntime.js" | ||
| }, | ||
| "./jsx-dev-runtime": { | ||
| "browser": "./jsx-runtime/dist/jsxRuntime.module.mjs", | ||
| "umd": "./jsx-runtime/dist/jsxRuntime.umd.js", | ||
| "import": "./jsx-runtime/dist/jsxRuntime.mjs", | ||
| "require": "./jsx-runtime/dist/jsxRuntime.js" | ||
|
|
@@ -69,7 +69,7 @@ | |
| "require": "./compat/client.js" | ||
| }, | ||
| "./compat/server": { | ||
| "browser": "./compat/server.browser.mjs", | ||
| "import": "./compat/server.mjs", | ||
| "require": "./compat/server.js" | ||
| }, | ||
|
|
@@ -203,7 +203,7 @@ | |
| "compat/src", | ||
| "compat/client.js", | ||
| "compat/client.mjs", | ||
| "compat/server.browser.mjs", | ||
| "compat/server.js", | ||
| "compat/server.mjs", | ||
| "compat/scheduler.js", | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we already have .mjs here, correct me if I'm wrong but apart from chromium browsers don't support the .mjs extension yet, so from what I can tell Jest should be using exports.import rather than exports.browser
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Browsers don’t care about the extension, they all support
.mjson that regard.Jest is using exports.browser when using the
jest-environment-jsdomenvironment, you may or may not agree with that but that’s how they’re doing it 😅 anyway, Preact should be using.mjs, or add"type": "module"and use.cjsextension for CJS file, otherwise it’s hurting their users that use tooling that follow the same logic as Node.js.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not, Node uses this correctly as it imports from
importand not frombrowserif Jest want to import from the browser tag it feels more appropriate to start disregarding thetype: modulestuff and rely on the browser semantics rather than the node ones 😅There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason not to use
.mjsthough?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The thing is we could change the export map to use
.mjsbut we would have to leave the.module.jsfile intact as people could be relying on that directly (unsafe though but let's try not to break people's stuff :p). Doing some quick checks and unpkg/skypack do leverage the correct mime when serving from their CDN. As we are not touching the UMD file we can be quite sure we don't have to check if people fill in the correct mime there 😅 CC @developit @marvinhagemeister are you seeing any issues here that I am overlooking?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the reason we didn't go with
.mjswas because it forced webpack into strict module mode which was causing duplicate copies of Preact for codebases with mixed import+require. I believe that problem is now solved via themoduleexport field, so we could move exclusively to using.mjs.