Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting translate through direct access does not work #3800

Merged
merged 6 commits into from
Feb 8, 2024
Merged

Setting translate through direct access does not work #3800

merged 6 commits into from
Feb 8, 2024

Conversation

JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Nov 15, 2022 •
edited
Loading

Fixes #3799

This changes our JSX type to reflect the fact that we support Boolean as a value for the property not yes and no.

However in compat we reflect Reacts behavior of supporting yes | no

For the record, React does not support booleans here https://stackblitz.com/edit/stackblitz-starters-tp34wv?description=React%20%20%20TypeScript%20starter%20project&file=src%2FApp.tsx&title=React%20Starter

@github-actions
Copy link

github-actions bot commented Nov 15, 2022 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -3% - +2% (-4.39ms - +3.46ms)
    preact-local vs preact-master
  • 02_replace1k: unsure 🔍 -1% - +2% (-0.90ms - +1.96ms)
    preact-local vs preact-main
  • 03_update10th1k_x16: unsure 🔍 -6% - +3% (-3.71ms - +1.57ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -1% - +6% (-0.39ms - +1.83ms)
    preact-local vs preact-main
  • 07_create10k: unsure 🔍 -1% - +2% (-19.71ms - +30.64ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +1% (-2.96ms - +5.96ms)
    preact-local vs preact-main
  • filter_list: unsure 🔍 -2% - +2% (-0.61ms - +0.49ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -1% - +1% (-0.13ms - +0.12ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -4% - +3% (-7.12ms - +4.30ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -3% - +1% (-2.00ms - +0.61ms)
    preact-local vs preact-main
  • many_updates: unsure 🔍 -5% - +4% (-1.50ms - +1.33ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -2% - +2% (-0.32ms - +0.29ms)
    preact-local vs preact-main
  • text_update: unsure 🔍 -2% - +1% (-0.05ms - +0.04ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -5% - +2% (-0.13ms - +0.06ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -2% - +4% (-0.95ms - +1.90ms)
    preact-local vs preact-master
  • todo: unsure 🔍 -0% - +2% (-0.06ms - +0.41ms)
    preact-local vs preact-main

usedJSHeapSize

  • 02_replace1k: unsure 🔍 -1% - +0% (-0.02ms - +0.01ms)
    preact-local vs preact-master
  • 02_replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-main
  • 07_create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • filter_list: unsure 🔍 -1% - +1% (-0.01ms - +0.01ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -0% - +1% (-0.03ms - +0.04ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • many_updates: unsure 🔍 -0% - +1% (-0.02ms - +0.03ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • text_update: unsure 🔍 -1% - +1% (-0.01ms - +0.01ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • todo: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main

Results

02_replace1k

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master157.41ms - 163.12ms-unsure 🔍
-2% - +3%
-3.46ms - +4.39ms		faster ✔
1% - 6%
1.46ms - 9.91ms
preact-local157.11ms - 162.50msunsure 🔍
-3% - +2%
-4.39ms - +3.46ms		-faster ✔
1% - 6%
2.03ms - 10.27ms
preact-hooks162.83ms - 169.07msslower ❌
1% - 6%
1.46ms - 9.91ms		slower ❌
1% - 6%
2.03ms - 10.27ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master3.27ms - 3.30ms-unsure 🔍
-0% - +1%
-0.01ms - +0.02ms		faster ✔
0% - 1%
0.00ms - 0.02ms
preact-local3.27ms - 3.30msunsure 🔍
-1% - +0%
-0.02ms - +0.01ms		-faster ✔
0% - 1%
0.00ms - 0.02ms
preact-hooks3.30ms - 3.30msslower ❌
0% - 1%
0.00ms - 0.02ms		slower ❌
0% - 1%
0.00ms - 0.02ms		-

run-warmup-0

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master52.41ms - 55.01ms-unsure 🔍
-1% - +5%
-0.73ms - +2.45ms		faster ✔
1% - 7%
0.67ms - 4.11ms
preact-local51.93ms - 53.78msunsure 🔍
-5% - +1%
-2.45ms - +0.73ms		-faster ✔
3% - 8%
1.80ms - 4.71ms
preact-hooks54.98ms - 57.23msslower ❌
1% - 8%
0.67ms - 4.11ms		slower ❌
3% - 9%
1.80ms - 4.71ms		-

run-warmup-1

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master76.62ms - 79.44ms-unsure 🔍
-3% - +2%
-2.06ms - +1.52ms		faster ✔
1% - 6%
0.57ms - 4.94ms
preact-local77.20ms - 79.40msunsure 🔍
-2% - +3%
-1.52ms - +2.06ms		-faster ✔
1% - 5%
0.49ms - 4.48ms
preact-hooks79.12ms - 82.45msslower ❌
1% - 6%
0.57ms - 4.94ms		slower ❌
1% - 6%
0.49ms - 4.48ms		-

run-warmup-2

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master67.58ms - 72.59ms-unsure 🔍
-5% - +5%
-3.31ms - +3.21ms		unsure 🔍
-2% - +10%
-1.37ms - +6.38ms
preact-local68.04ms - 72.22msunsure 🔍
-5% - +5%
-3.21ms - +3.31ms		-unsure 🔍
-2% - +9%
-1.07ms - +6.17ms
preact-hooks64.62ms - 70.53msunsure 🔍
-9% - +2%
-6.38ms - +1.37ms		unsure 🔍
-9% - +1%
-6.17ms - +1.07ms		-

run-warmup-3

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master42.29ms - 47.09ms-unsure 🔍
-5% - +9%
-2.15ms - +4.12ms		faster ✔
10% - 24%
4.66ms - 13.14ms
preact-local41.69ms - 45.72msunsure 🔍
-9% - +5%
-4.12ms - +2.15ms		-faster ✔
12% - 25%
5.84ms - 13.92ms
preact-hooks50.09ms - 57.09msslower ❌
10% - 30%
4.66ms - 13.14ms		slower ❌
13% - 32%
5.84ms - 13.92ms		-

run-warmup-4

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master64.56ms - 67.44ms-unsure 🔍
-4% - +3%
-2.33ms - +1.76ms		slower ❌
0% - 8%
0.25ms - 4.87ms
preact-local64.83ms - 67.74msunsure 🔍
-3% - +4%
-1.76ms - +2.33ms		-slower ❌
1% - 8%
0.53ms - 5.16ms
preact-hooks61.64ms - 65.24msfaster ✔
0% - 7%
0.25ms - 4.87ms		faster ✔
1% - 8%
0.53ms - 5.16ms		-

run-final

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master44.65ms - 49.61ms-unsure 🔍
-8% - +6%
-3.79ms - +2.95ms		faster ✔
2% - 16%
1.10ms - 8.63ms
preact-local45.26ms - 49.83msunsure 🔍
-6% - +8%
-2.95ms - +3.79ms		-faster ✔
2% - 15%
0.80ms - 8.08ms
preact-hooks49.16ms - 54.83msslower ❌
2% - 19%
1.10ms - 8.63ms		slower ❌
1% - 17%
0.80ms - 8.08ms		-
02_replace1k

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main80.31ms - 82.46ms-unsure 🔍
-2% - +1%
-1.96ms - +0.90ms		unsure 🔍
-2% - +1%
-1.86ms - +0.72ms
preact-local80.97ms - 82.86msunsure 🔍
-1% - +2%
-0.90ms - +1.96ms		-unsure 🔍
-1% - +1%
-1.23ms - +1.14ms
preact-hooks81.25ms - 82.67msunsure 🔍
-1% - +2%
-0.72ms - +1.86ms		unsure 🔍
-1% - +1%
-1.14ms - +1.23ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main3.48ms - 3.48ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		faster ✔
1% - 1%
0.02ms - 0.02ms
preact-local3.48ms - 3.48msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-faster ✔
1% - 1%
0.02ms - 0.02ms
preact-hooks3.50ms - 3.50msslower ❌
1% - 1%
0.02ms - 0.02ms		slower ❌
1% - 1%
0.02ms - 0.02ms		-

run-warmup-0

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main30.85ms - 31.88ms-unsure 🔍
-3% - +2%
-0.81ms - +0.66ms		unsure 🔍
-2% - +2%
-0.68ms - +0.69ms
preact-local30.92ms - 31.97msunsure 🔍
-2% - +3%
-0.66ms - +0.81ms		-unsure 🔍
-2% - +2%
-0.61ms - +0.77ms
preact-hooks30.91ms - 31.81msunsure 🔍
-2% - +2%
-0.69ms - +0.68ms		unsure 🔍
-2% - +2%
-0.77ms - +0.61ms		-

run-warmup-1

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main40.21ms - 41.74ms-unsure 🔍
-3% - +2%
-1.21ms - +0.97ms		faster ✔
0% - 5%
0.19ms - 2.10ms
preact-local40.32ms - 41.87msunsure 🔍
-2% - +3%
-0.97ms - +1.21ms		-faster ✔
0% - 5%
0.07ms - 1.98ms
preact-hooks41.56ms - 42.68msslower ❌
0% - 5%
0.19ms - 2.10ms		slower ❌
0% - 5%
0.07ms - 1.98ms		-

run-warmup-2

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main27.50ms - 27.96ms-unsure 🔍
-2% - +0%
-0.52ms - +0.09ms		unsure 🔍
-2% - +0%
-0.61ms - +0.03ms
preact-local27.74ms - 28.15msunsure 🔍
-0% - +2%
-0.09ms - +0.52ms		-unsure 🔍
-1% - +1%
-0.38ms - +0.22ms
preact-hooks27.80ms - 28.25msunsure 🔍
-0% - +2%
-0.03ms - +0.61ms		unsure 🔍
-1% - +1%
-0.22ms - +0.38ms		-

run-warmup-3

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main25.93ms - 26.98ms-unsure 🔍
-3% - +3%
-0.71ms - +0.80ms		unsure 🔍
-6% - +0%
-1.57ms - +0.07ms
preact-local25.87ms - 26.96msunsure 🔍
-3% - +3%
-0.80ms - +0.71ms		-unsure 🔍
-6% - +0%
-1.62ms - +0.04ms
preact-hooks26.57ms - 27.83msunsure 🔍
-0% - +6%
-0.07ms - +1.57ms		unsure 🔍
-0% - +6%
-0.04ms - +1.62ms		-

run-warmup-4

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main28.63ms - 30.38ms-unsure 🔍
-4% - +4%
-1.23ms - +1.14ms		faster ✔
2% - 8%
0.55ms - 2.56ms
preact-local28.76ms - 30.35msunsure 🔍
-4% - +4%
-1.14ms - +1.23ms		-faster ✔
2% - 8%
0.57ms - 2.44ms
preact-hooks30.57ms - 31.55msslower ❌
2% - 9%
0.55ms - 2.56ms		slower ❌
2% - 8%
0.57ms - 2.44ms		-

run-final

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main23.19ms - 24.28ms-unsure 🔍
-4% - +2%
-0.98ms - +0.59ms		unsure 🔍
-3% - +3%
-0.71ms - +0.61ms
preact-local23.36ms - 24.50msunsure 🔍
-3% - +4%
-0.59ms - +0.98ms		-unsure 🔍
-2% - +3%
-0.54ms - +0.83ms
preact-hooks23.41ms - 24.16msunsure 🔍
-3% - +3%
-0.61ms - +0.71ms		unsure 🔍
-3% - +2%
-0.83ms - +0.54ms		-
03_update10th1k_x16

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master56.37ms - 60.09ms-unsure 🔍
-3% - +7%
-1.57ms - +3.71ms		unsure 🔍
-3% - +7%
-1.66ms - +3.84ms
preact-local55.29ms - 59.03msunsure 🔍
-6% - +3%
-3.71ms - +1.57ms		-unsure 🔍
-5% - +5%
-2.74ms - +2.78ms
preact-hooks55.11ms - 59.17msunsure 🔍
-7% - +3%
-3.84ms - +1.66ms		unsure 🔍
-5% - +5%
-2.78ms - +2.74ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master3.23ms - 3.24ms-unsure 🔍
-0% - +0%
-0.01ms - +0.01ms		faster ✔
0% - 1%
0.01ms - 0.02ms
preact-local3.23ms - 3.24msunsure 🔍
-0% - +0%
-0.01ms - +0.01ms		-faster ✔
0% - 1%
0.01ms - 0.02ms
preact-hooks3.24ms - 3.25msslower ❌
0% - 1%
0.01ms - 0.02ms		slower ❌
0% - 1%
0.01ms - 0.02ms		-
03_update10th1k_x16

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main30.00ms - 31.59ms-unsure 🔍
-6% - +1%
-1.83ms - +0.39ms		unsure 🔍
-6% - +1%
-1.93ms - +0.26ms
preact-local30.74ms - 32.29msunsure 🔍
-1% - +6%
-0.39ms - +1.83ms		-unsure 🔍
-4% - +3%
-1.19ms - +0.97ms
preact-hooks30.88ms - 32.38msunsure 🔍
-1% - +6%
-0.26ms - +1.93ms		unsure 🔍
-3% - +4%
-0.97ms - +1.19ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main3.44ms - 3.44ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms		faster ✔
1% - 1%
0.02ms - 0.03ms
preact-local3.44ms - 3.45msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms		-faster ✔
0% - 1%
0.01ms - 0.02ms
preact-hooks3.46ms - 3.47msslower ❌
1% - 1%
0.02ms - 0.03ms		slower ❌
0% - 1%
0.01ms - 0.02ms		-
07_create10k

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master1983.66ms - 2021.73ms-unsure 🔍
-2% - +1%
-30.64ms - +19.71ms		unsure 🔍
-2% - +0%
-46.77ms - +6.65ms
preact-local1991.69ms - 2024.64msunsure 🔍
-1% - +2%
-19.71ms - +30.64ms		-unsure 🔍
-2% - +1%
-39.54ms - +10.35ms
preact-hooks2004.03ms - 2041.49msunsure 🔍
-0% - +2%
-6.65ms - +46.77ms		unsure 🔍
-1% - +2%
-10.35ms - +39.54ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master25.31ms - 25.31ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-local25.31ms - 25.31msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-hooks25.33ms - 25.33msunsure 🔍
+0% - +0%
+0.02ms - +0.02ms		unsure 🔍
+0% - +0%
+0.02ms - +0.02ms		-
07_create10k

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main913.29ms - 919.48ms-unsure 🔍
-1% - +0%
-5.96ms - +2.96ms		unsure 🔍
-1% - +0%
-6.25ms - +2.68ms
preact-local914.68ms - 921.10msunsure 🔍
-0% - +1%
-2.96ms - +5.96ms		-unsure 🔍
-1% - +0%
-4.83ms - +4.26ms
preact-hooks914.96ms - 921.38msunsure 🔍
-0% - +1%
-2.68ms - +6.25ms		unsure 🔍
-0% - +1%
-4.26ms - +4.83ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main26.48ms - 26.48ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-local26.48ms - 26.48msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-hooks26.50ms - 26.50msunsure 🔍
+0% - +0%
+0.02ms - +0.02ms		unsure 🔍
+0% - +0%
+0.02ms - +0.02ms		-
filter_list

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master24.19ms - 25.02ms-unsure 🔍
-2% - +2%
-0.49ms - +0.61ms		unsure 🔍
-2% - +2%
-0.56ms - +0.57ms
preact-local24.19ms - 24.90msunsure 🔍
-2% - +2%
-0.61ms - +0.49ms		-unsure 🔍
-2% - +2%
-0.58ms - +0.46ms
preact-hooks24.22ms - 24.98msunsure 🔍
-2% - +2%
-0.57ms - +0.56ms		unsure 🔍
-2% - +2%
-0.46ms - +0.58ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master1.37ms - 1.38ms-unsure 🔍
-1% - +1%
-0.01ms - +0.01ms		faster ✔
1% - 2%
0.01ms - 0.03ms
preact-local1.37ms - 1.39msunsure 🔍
-1% - +1%
-0.01ms - +0.01ms		-faster ✔
1% - 2%
0.01ms - 0.03ms
preact-hooks1.39ms - 1.41msslower ❌
1% - 3%
0.01ms - 0.03ms		slower ❌
1% - 3%
0.01ms - 0.03ms		-
filter_list

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main16.65ms - 16.86ms-unsure 🔍
-1% - +1%
-0.12ms - +0.13ms		unsure 🔍
-1% - +1%
-0.08ms - +0.18ms
preact-local16.68ms - 16.82msunsure 🔍
-1% - +1%
-0.13ms - +0.12ms		-unsure 🔍
-0% - +1%
-0.06ms - +0.15ms
preact-hooks16.63ms - 16.78msunsure 🔍
-1% - +1%
-0.18ms - +0.08ms		unsure 🔍
-1% - +0%
-0.15ms - +0.06ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main1.49ms - 1.49ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		faster ✔
1% - 2%
0.02ms - 0.03ms
preact-local1.49ms - 1.49msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-faster ✔
1% - 2%
0.02ms - 0.03ms
preact-hooks1.52ms - 1.52msslower ❌
1% - 2%
0.02ms - 0.03ms		slower ❌
1% - 2%
0.02ms - 0.03ms		-
hydrate1k

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master161.90ms - 168.81ms-unsure 🔍
-3% - +4%
-4.30ms - +7.12ms		unsure 🔍
-1% - +4%
-2.28ms - +7.29ms
preact-local159.39ms - 168.48msunsure 🔍
-4% - +3%
-7.12ms - +4.30ms		-unsure 🔍
-3% - +4%
-4.53ms - +6.71ms
preact-hooks159.54ms - 166.16msunsure 🔍
-4% - +1%
-7.29ms - +2.28ms		unsure 🔍
-4% - +3%
-6.71ms - +4.53ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master5.93ms - 5.98ms-unsure 🔍
-1% - +0%
-0.04ms - +0.03ms		faster ✔
0% - 1%
0.00ms - 0.07ms
preact-local5.93ms - 5.98msunsure 🔍
-0% - +1%
-0.03ms - +0.04ms		-unsure 🔍
-1% - +0%
-0.06ms - +0.00ms
preact-hooks5.97ms - 6.01msslower ❌
0% - 1%
0.00ms - 0.07ms		unsure 🔍
-0% - +1%
-0.00ms - +0.06ms		-
hydrate1k

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main75.98ms - 78.41ms-unsure 🔍
-1% - +3%
-0.61ms - +2.00ms		unsure 🔍
-2% - +2%
-1.60ms - +1.68ms
preact-local76.03ms - 76.97msunsure 🔍
-3% - +1%
-2.00ms - +0.61ms		-unsure 🔍
-2% - +1%
-1.85ms - +0.55ms
preact-hooks76.05ms - 78.26msunsure 🔍
-2% - +2%
-1.68ms - +1.60ms		unsure 🔍
-1% - +2%
-0.55ms - +1.85ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main6.18ms - 6.18ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		unsure 🔍
-0% - -0%
-0.03ms - -0.02ms
preact-local6.18ms - 6.18msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-unsure 🔍
-0% - -0%
-0.03ms - -0.02ms
preact-hooks6.20ms - 6.20msunsure 🔍
+0% - +0%
+0.02ms - +0.03ms		unsure 🔍
+0% - +0%
+0.02ms - +0.03ms		-
many_updates

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master29.69ms - 31.85ms-unsure 🔍
-4% - +5%
-1.33ms - +1.50ms		unsure 🔍
-4% - +5%
-1.30ms - +1.43ms
preact-local29.78ms - 31.60msunsure 🔍
-5% - +4%
-1.50ms - +1.33ms		-unsure 🔍
-4% - +4%
-1.26ms - +1.22ms
preact-hooks29.87ms - 31.54msunsure 🔍
-5% - +4%
-1.43ms - +1.30ms		unsure 🔍
-4% - +4%
-1.22ms - +1.26ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master4.43ms - 4.46ms-unsure 🔍
-1% - +0%
-0.03ms - +0.02ms		faster ✔
0% - 1%
0.00ms - 0.06ms
preact-local4.43ms - 4.46msunsure 🔍
-0% - +1%
-0.02ms - +0.03ms		-faster ✔
0% - 1%
0.00ms - 0.05ms
preact-hooks4.46ms - 4.49msslower ❌
0% - 1%
0.00ms - 0.06ms		slower ❌
0% - 1%
0.00ms - 0.05ms		-
many_updates

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main16.65ms - 16.86ms-unsure 🔍
-2% - +2%
-0.29ms - +0.32ms		unsure 🔍
-4% - +1%
-0.62ms - +0.10ms
preact-local16.46ms - 17.02msunsure 🔍
-2% - +2%
-0.32ms - +0.29ms		-unsure 🔍
-4% - +1%
-0.72ms - +0.17ms
preact-hooks16.67ms - 17.35msunsure 🔍
-1% - +4%
-0.10ms - +0.62ms		unsure 🔍
-1% - +4%
-0.17ms - +0.72ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main4.60ms - 4.60ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-local4.60ms - 4.60msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-hooks4.62ms - 4.62msslower ❌
0% - 1%
0.02ms - 0.02ms		unsure 🔍
+0% - +0%
+0.02ms - +0.02ms		-
text_update

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master2.71ms - 2.77ms-unsure 🔍
-1% - +2%
-0.04ms - +0.05ms		faster ✔
4% - 7%
0.12ms - 0.21ms
preact-local2.70ms - 2.76msunsure 🔍
-2% - +1%
-0.05ms - +0.04ms		-faster ✔
4% - 7%
0.13ms - 0.22ms
preact-hooks2.87ms - 2.94msslower ❌
4% - 8%
0.12ms - 0.21ms		slower ❌
5% - 8%
0.13ms - 0.22ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master0.63ms - 0.64ms-unsure 🔍
-1% - +1%
-0.01ms - +0.01ms		faster ✔
1% - 3%
0.01ms - 0.02ms
preact-local0.62ms - 0.63msunsure 🔍
-1% - +1%
-0.01ms - +0.01ms		-faster ✔
1% - 3%
0.01ms - 0.02ms
preact-hooks0.64ms - 0.65msslower ❌
1% - 3%
0.01ms - 0.02ms		slower ❌
1% - 3%
0.01ms - 0.02ms		-
text_update

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main2.50ms - 2.63ms-unsure 🔍
-2% - +5%
-0.06ms - +0.13ms		faster ✔
5% - 12%
0.14ms - 0.34ms
preact-local2.47ms - 2.59msunsure 🔍
-5% - +2%
-0.13ms - +0.06ms		-faster ✔
7% - 13%
0.18ms - 0.37ms
preact-hooks2.73ms - 2.88msslower ❌
5% - 13%
0.14ms - 0.34ms		slower ❌
7% - 15%
0.18ms - 0.37ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main0.72ms - 0.72ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms		faster ✔
3% - 3%
0.02ms - 0.02ms
preact-local0.72ms - 0.72msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms		-faster ✔
3% - 3%
0.02ms - 0.02ms
preact-hooks0.75ms - 0.75msslower ❌
3% - 3%
0.02ms - 0.02ms		slower ❌
3% - 3%
0.02ms - 0.02ms		-
todo

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master44.48ms - 46.13ms-unsure 🔍
-4% - +2%
-1.90ms - +0.95ms		unsure 🔍
-4% - +0%
-1.78ms - +0.16ms
preact-local44.62ms - 46.94msunsure 🔍
-2% - +4%
-0.95ms - +1.90ms		-unsure 🔍
-3% - +2%
-1.60ms - +0.93ms
preact-hooks45.61ms - 46.63msunsure 🔍
-0% - +4%
-0.16ms - +1.78ms		unsure 🔍
-2% - +4%
-0.93ms - +1.60ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master0.84ms - 0.84ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		faster ✔
3% - 3%
0.02ms - 0.03ms
preact-local0.84ms - 0.84msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-faster ✔
3% - 3%
0.02ms - 0.03ms
preact-hooks0.87ms - 0.87msslower ❌
3% - 3%
0.02ms - 0.03ms		slower ❌
3% - 3%
0.02ms - 0.03ms		-
todo

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main26.46ms - 26.66ms-unsure 🔍
-2% - +0%
-0.41ms - +0.06ms		faster ✔
2% - 4%
0.61ms - 1.03ms
preact-local26.52ms - 26.95msunsure 🔍
-0% - +2%
-0.06ms - +0.41ms		-faster ✔
1% - 3%
0.36ms - 0.93ms
preact-hooks27.19ms - 27.57msslower ❌
2% - 4%
0.61ms - 1.03ms		slower ❌
1% - 4%
0.36ms - 0.93ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main0.95ms - 0.95ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms		faster ✔
3% - 3%
0.03ms - 0.03ms
preact-local0.95ms - 0.95msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms		-faster ✔
3% - 3%
0.03ms - 0.03ms
preact-hooks0.98ms - 0.98msslower ❌
3% - 3%
0.03ms - 0.03ms		slower ❌
3% - 3%
0.03ms - 0.03ms		-

tachometer-reporter-action v2 for Benchmarks

@coveralls
Copy link

coveralls commented Nov 15, 2022 •
edited
Loading

Coverage Status

coverage: 99.472% (-0.001%) from 99.473%
when pulling 8b1e3ad on fix-translate-setting
into 6992228 on main.

@github-actions
Copy link

github-actions bot commented Nov 15, 2022 •
edited
Loading

Size Change: +39 B (0%)

Total Size: 60.1 kB

Filename Size Change
compat/dist/compat.js 4 kB +13 B (0%)
compat/dist/compat.module.js 3.92 kB +13 B (0%)
compat/dist/compat.umd.js 4.06 kB +13 B (0%)
ℹ️ View Unchanged
Filename Size Change
debug/dist/debug.js 3.52 kB 0 B
debug/dist/debug.module.js 3.52 kB 0 B
debug/dist/debug.umd.js 3.6 kB 0 B
devtools/dist/devtools.js 232 B 0 B
devtools/dist/devtools.module.js 241 B 0 B
devtools/dist/devtools.umd.js 316 B 0 B
dist/preact.js 4.54 kB 0 B
dist/preact.min.js 4.58 kB 0 B
dist/preact.min.module.js 4.58 kB 0 B
dist/preact.min.umd.js 4.61 kB 0 B
dist/preact.module.js 4.57 kB 0 B
dist/preact.umd.js 4.62 kB 0 B
hooks/dist/hooks.js 1.55 kB 0 B
hooks/dist/hooks.module.js 1.59 kB 0 B
hooks/dist/hooks.umd.js 1.63 kB 0 B
jsx-runtime/dist/jsxRuntime.js 963 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 938 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 1.04 kB 0 B
test-utils/dist/testUtils.js 453 B 0 B
test-utils/dist/testUtils.module.js 454 B 0 B
test-utils/dist/testUtils.umd.js 536 B 0 B

compressed-size-action

marvinhagemeister
marvinhagemeister reviewed Nov 15, 2022
View reviewed changes
Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Let's add a test for that 👍

@developit
Copy link
Member

I feel like this might be better suited to compat. The correct usage would be translate={false}, right?

@JoviDeCroock
Copy link
Member Author

JoviDeCroock commented Nov 15, 2022 •
edited
Loading

@developit it's a valid attribute value so I would say this belongs in core. The attribute is correctly treated with setAttribute.

EDIT: will create a test later, was a phone PR

@marvinhagemeister
Copy link
Member

@developit both "yes" and "no" are valid values according to mdn: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/translate .

@developit
Copy link
Member

@marvinhagemeister those values are for the attribute, not the property.

@JoviDeCroock
Copy link
Member Author

Closing due to inactivity

@JoviDeCroock JoviDeCroock deleted the fix-translate-setting branch April 24, 2023 10:42
@JoviDeCroock JoviDeCroock restored the fix-translate-setting branch May 18, 2023 11:19
@JoviDeCroock JoviDeCroock deleted the fix-translate-setting branch May 18, 2023 11:19
@JoviDeCroock JoviDeCroock restored the fix-translate-setting branch May 18, 2023 11:19
@JoviDeCroock JoviDeCroock reopened this May 18, 2023
@trevoring-okta
Copy link

Hi! Is there an update on whether this will be merged and released?

@denysoblohin-okta denysoblohin-okta mentioned this pull request Jan 12, 2024
Merged
5 tasks
@trevoring-okta trevoring-okta mentioned this pull request Jan 12, 2024
Merged
5 tasks
@trevoring-okta
Copy link

@JoviDeCroock 👋 Bumping my comment above about whether this PR will be merged in at any point? Our team had to do a manual patch of preact using patch-package to pull in this exact change that you have here and unblock our use of translate

@JoviDeCroock JoviDeCroock merged commit 72cbd2d into main Feb 8, 2024
3 checks passed
@JoviDeCroock JoviDeCroock deleted the fix-translate-setting branch February 8, 2024 07:26
@JoviDeCroock JoviDeCroock mentioned this pull request Feb 16, 2024
Merged
@X-oss-byte X-oss-byte mentioned this pull request May 21, 2024
Open
@q1blue q1blue mentioned this pull request May 24, 2024
Open
@Leeze555 Leeze555 mentioned this pull request May 31, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Jun 5, 2024
Open
@Jircs1 Jircs1 mentioned this pull request Jun 10, 2024
Open
This was referenced Jun 15, 2024
Open
Open
Open
@vAHiD55555 vAHiD55555 mentioned this pull request Jun 20, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Jul 22, 2024
Open
@rschristian rschristian mentioned this pull request Jul 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister left review comments

@andrewiggins andrewiggins andrewiggins approved these changes

@developit developit Awaiting requested review from developit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

translate="no" becomes translate="yes"
6 participants
@JoviDeCroock @coveralls @developit @marvinhagemeister @trevoring-okta @andrewiggins