compat PureComponent parity with upstream react type definitions #4056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Type parity with upstream for PureComponent
| @@ -106,7 +106,7 @@ declare namespace React { | |||
| component: preact.Component | Element | |||
| ): Element | null; | |||
|
|
|||
| export abstract class PureComponent<P = {}, S = {}> extends preact.Component< | |||
| export abstract class PureComponent<P = {}, S = {}, SS = any> extends preact.Component< | |||
There was a problem hiding this comment.
Should we then also accept this on Component to orchestrate typings for getSnapshotBeforeUpdate as React does
There was a problem hiding this comment.
Sorry, I actually have no idea about any of that as I'm pretty new to using React/Preact, just thought I'd contribute a fix to get Blueprint working since it's just a small issue with types.
|
@JoviDeCroock any chance this will be merged? Looking into using Blueprint with Preact as well. |
JoviDeCroock
approved these changes
Nov 6, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PureComponent parity with react type definitions, fixes palantir/blueprint#5498 + similar issues in blueprint when using preact, as many of the components extend PureComponent.
cf https://github.com/DefinitelyTyped/DefinitelyTyped/blob/b28468368df0b6ed8d4cf33683cc46087004d4f4/types/react/index.d.ts#L537