Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align state updater type #4306

Merged
merged 1 commit into from
Mar 17, 2024
Merged

align state updater type #4306

merged 1 commit into from
Mar 17, 2024

Conversation

JoviDeCroock
Copy link
Member

Fixes #4285

Copy link

Size Change: 0 B

Total Size: 60 kB

ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 4 kB 0 B
compat/dist/compat.module.js 3.92 kB 0 B
compat/dist/compat.umd.js 4.06 kB 0 B
debug/dist/debug.js 3.52 kB 0 B
debug/dist/debug.module.js 3.52 kB 0 B
debug/dist/debug.umd.js 3.6 kB 0 B
devtools/dist/devtools.js 232 B 0 B
devtools/dist/devtools.module.js 241 B 0 B
devtools/dist/devtools.umd.js 316 B 0 B
dist/preact.js 4.53 kB 0 B
dist/preact.min.js 4.57 kB 0 B
dist/preact.min.module.js 4.56 kB 0 B
dist/preact.min.umd.js 4.6 kB 0 B
dist/preact.module.js 4.55 kB 0 B
dist/preact.umd.js 4.61 kB 0 B
hooks/dist/hooks.js 1.55 kB 0 B
hooks/dist/hooks.module.js 1.59 kB 0 B
hooks/dist/hooks.umd.js 1.63 kB 0 B
jsx-runtime/dist/jsxRuntime.js 963 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 938 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 1.04 kB 0 B
test-utils/dist/testUtils.js 453 B 0 B
test-utils/dist/testUtils.module.js 454 B 0 B
test-utils/dist/testUtils.umd.js 536 B 0 B

compressed-size-action

@coveralls
Copy link

Coverage Status

coverage: 99.467%. remained the same
when pulling 230a6f5 on align-state-updater-impl
into dc55841 on main.

@JoviDeCroock JoviDeCroock merged commit f8a0801 into main Mar 17, 2024
5 checks passed
@JoviDeCroock JoviDeCroock deleted the align-state-updater-impl branch March 17, 2024 18:32
@JoviDeCroock JoviDeCroock mentioned this pull request Mar 18, 2024
@evtn
Copy link

evtn commented Sep 30, 2024

A bit late to the party, but changing public type definitions within patch versions is not ideal, I just had spent an hour trying to figure out why did my project stopped passing typecheck on CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

preact/compat's SetStateAction is different from React's SetStateAction
5 participants