Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bring consistency to our focus events #4307

Merged
merged 2 commits into from
Mar 17, 2024
Merged

Conversation

JoviDeCroock
Copy link
Member

Fixes #4289

We could leave the lower cased ones in for backwards compatibility, floating this to have a consistent file

@coveralls
Copy link

coveralls commented Mar 17, 2024

Coverage Status

coverage: 99.467%. remained the same
when pulling 06a4bbb on consistency-focus-events
into cfba5ee on main.

Copy link
Member

@rschristian rschristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's necessary to keep the lower-cased versions around. Should be a quick adjustment and is pretty clearly a mistake

@JoviDeCroock JoviDeCroock merged commit a2c12f5 into main Mar 17, 2024
1 check passed
@JoviDeCroock JoviDeCroock deleted the consistency-focus-events branch March 17, 2024 18:40
@JoviDeCroock JoviDeCroock mentioned this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript JSX focus events don't have consistent case
4 participants