Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Merge upload actions to fix usage in v4 #4515

Merged
merged 4 commits into from
Oct 1, 2024
Merged

ci: Merge upload actions to fix usage in v4 #4515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6318a55
ci: Merge upload actions to avoid issues
rschristian Sep 28, 2024
6e6d5a3
ci: Ensure bench reports are uploaded w/ unique names
rschristian Sep 28, 2024
cb5df4c
ci: Fix artifact names
rschristian Sep 28, 2024
871010a
ci: Access name for result correctly
rschristian Sep 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions .github/workflows/benchmarks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,23 +30,20 @@ jobs:
with:
name: npm-package
- run: mv preact.tgz preact-local.tgz
- name: Upload locally built preact package
uses: actions/upload-artifact@v4
with:
name: bench-environment
path: preact-local.tgz
- name: Download base package
uses: andrewiggins/download-base-artifact@v3
with:
artifact: npm-package
workflow: ci.yml
required: false
- run: mv preact.tgz preact-main.tgz
- name: Upload base preact package
- name: Upload locally build & base preact package
uses: actions/upload-artifact@v4
with:
name: bench-environment
path: preact-main.tgz
path: |
preact-local.tgz
preact-main.tgz

bench_todo:
name: Bench todo
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/run-bench.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,11 +107,12 @@ jobs:
id: log-artifact-name
run: |
NAME=$(echo "${{ inputs.benchmark }}" | sed -r 's/[\/]+/_/g')
echo "clean_name=$NAME" >> $GITHUB_OUTPUT
echo "artifact_name=logs_$NAME" >> $GITHUB_OUTPUT
- name: Upload results
uses: actions/upload-artifact@v4
with:
name: results
name: results-${{ steps.log-artifact-name.outputs.clean_name }}
path: benchmarks/out/results/${{ inputs.benchmark }}.json
- name: Upload logs
uses: actions/upload-artifact@v4
Expand Down
11 changes: 4 additions & 7 deletions .github/workflows/single-bench.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,6 @@ jobs:
with:
name: npm-package
- run: mv preact.tgz preact-local.tgz
- name: Upload locally built preact package
uses: actions/upload-artifact@v4
with:
name: bench-environment
path: preact-local.tgz
- name: Clear working directory
run: |
ls -al
Expand All @@ -77,11 +72,13 @@ jobs:
with:
name: base-npm-package
- run: mv preact.tgz preact-main.tgz
- name: Upload base preact package
- name: Upload locally built & base preact package
uses: actions/upload-artifact@v4
with:
name: bench-environment
path: preact-main.tgz
path: |
preact-local.tgz
preact-main.tgz

benchmark:
name: Bench ${{ inputs.benchmark }}
Expand Down