Skip to content

Commit

Permalink
Add user sync to process for approving adapter PRs (#1457)
Browse files Browse the repository at this point in the history
  • Loading branch information
grevory authored and dbemiller committed Sep 18, 2017
1 parent 0298b7f commit 1733da7
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions pr_review.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,4 @@ We take PR review seriously. Please read https://medium.com/@mrjoelkemp/giving-b
- Verify that the bidder is being as efficient as possible, ideally not loading an external library, however if they do load a library it should be cached.
- Verify that code re-use is being done properly and that changes introduced by a bidder don't impact other bidders.
- If the adapter being submitted is an alias type, check with the bidder contact that is being aliased to make sure it's allowed.
- If the adapter is triggering any user syncs make sure they are using the user sync module in the Prebid.js core.

0 comments on commit 1733da7

Please sign in to comment.