#17 - bid adjustments per bidder

prebid · Dec 8, 2015 · 709ac01 · 709ac01
1 parent 601adf4
commit 709ac01
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 6 deletions.
diff --git a/integrationExamples/gpt/pbjs_example_gpt.html b/integrationExamples/gpt/pbjs_example_gpt.html
@@ -221,6 +221,9 @@
             ]
         },
         appnexus: {
+            bidCpmAdjustment : function(bidCpm){
+                return bidCpm * .9;
+            },
             alwaysUseBid : true, // <-- new field - always send these custom keys for the specified bidder
             adserverTargeting: [{
                 key: "custom_bidder",

diff --git a/src/bidmanager.js b/src/bidmanager.js
@@ -33,8 +33,6 @@ var _callbackExecuted = false;
 var defaultBidderSettingsMap = {};
 var bidderStartTimes = {};
 
-var countme = 0;
-
 exports.getPlacementIdByCBIdentifer = function(id) {
 	return pbCallbackMap[id];
 };
@@ -148,8 +146,10 @@ exports.addBidResponse = function(adUnitCode, bid) {
 			bid.cpm = 0;
 		}
 
+		//emit the bidAdjustment event before bidResponse, so bid response has the adjusted bid value
+		events.emit(CONSTANTS.EVENTS.BID_ADJUSTMENT, bid);
 		//emit the bidResponse event
-		events.emit('bidResponse', adUnitCode, bid);
+		events.emit(CONSTANTS.EVENTS.BID_RESPONSE, adUnitCode, bid);
 
 		var priceStringsObj = utils.getPriceBucketString(bid.cpm, bid.height, bid.width);
 		//append price strings
@@ -434,16 +434,21 @@ exports.addCallback = function(id, callback, cbEvent){
 };
 
 //register event for bid adjustment
-events.on(CONSTANTS.EVENTS.BID_RESPONSE, function(adunit, bid) {
+events.on(CONSTANTS.EVENTS.BID_ADJUSTMENT, function(bid) {
 	adjustBids(bid);
 });
 
 function adjustBids(bid){
 	var code = bid.bidderCode;
-	var bidPriceAdjusted = 0; 
+	var bidPriceAdjusted = bid.cpm; 
 	if(code && pbjs.bidderSettings[code]){
 		if(typeof pbjs.bidderSettings[code].bidCpmAdjustment === objectType_function){
-			bidPriceAdjusted = pbjs.bidderSettings[code].bidCpmAdjustment.call(null, bid.cpm);
+			try{
+				bidPriceAdjusted = pbjs.bidderSettings[code].bidCpmAdjustment.call(null, bid.cpm);
+			}
+			catch(e){
+				utils.logError('Error during bid adjustment', 'bidmanager.js', e);
+			}
 		}
 	}
 

diff --git a/src/constants.json b/src/constants.json
@@ -28,6 +28,7 @@
 
 
 	"EVENTS" : {
+		"BID_ADJUSTMENT" : "bidAdjustment",
 		"BID_TIMEOUT" : "bidTimeout",
 		"BID_REQUESTED" : "bidRequested",
 		"BID_RESPONSE" : "bidResponse",