Minor fixes

prebid · Aug 31, 2021 · e6812c7 · e6812c7
1 parent bdc0043
commit e6812c7
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 15 deletions.
diff --git a/modules/publinkIdSystem.js b/modules/publinkIdSystem.js
@@ -67,9 +67,13 @@ function getlocalValue() {
     }
 
     if (typeof value === 'string') {
-      const obj = JSON.parse(value);
-      if (obj && obj.exp > Date.now()) {
-        return obj.publink;
+      try {
+        const obj = JSON.parse(value);
+        if (obj && obj.exp && obj.exp > Date.now()) {
+          return obj.publink;
+        }
+      } catch (e) {
+        utils.logError(e);
       }
     }
   }
@@ -101,21 +105,19 @@ export const publinkIdSubmodule = {
 
   /**
    * performs action to obtain id
+   * Use a publink cookie first if it is present, otherwise use prebids copy, if neither are available callout to get a new id
    * @function
    * @param {SubmoduleConfig} [config] Config object with params and storage properties
    * @returns {IdResponse}
    */
   getId: function(config, consentData, storedId) {
-    let result = {};
-    const storedValue = getlocalValue();
-    if (storedValue) {
-      result.id = storedValue;
+    const localValue = getlocalValue();
+    if (localValue) {
+      return {id: localValue};
     }
-    if (storedId) {
-      result.id = storedId;
+    if (!storedId) {
+      return {callback: makeCallback(config, consentData)};
     }
-    result.callback = makeCallback(config, consentData);
-    return result;
   }
 };
 submodule('userId', publinkIdSubmodule);
diff --git a/test/spec/modules/publinkIdSystem_spec.js b/test/spec/modules/publinkIdSystem_spec.js
@@ -69,11 +69,9 @@ describe('PublinkIdSystem', () => {
       expect(result).to.exist;
       expect(result.callback).to.be.a('function');
     });
-    it('Use local id', () => {
+    it('Use local copy', () => {
       const result = publinkIdSubmodule.getId({}, undefined, TEST_COOKIE_VALUE);
-      expect(result).to.exist;
-      expect(result.id).to.equal(TEST_COOKIE_VALUE);
-      expect(result.callback).to.be.a('function');
+      expect(result).to.be.undefined;
     });
 
     describe('callout for id', () => {