Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing parameters in bidAdjustment events #1398

Closed
kir-roxot opened this issue Jul 20, 2017 · 4 comments
Closed

Missing parameters in bidAdjustment events #1398

kir-roxot opened this issue Jul 20, 2017 · 4 comments
Assignees
@dbemiller

Comments

@kir-roxot
Copy link
Contributor

Type of issue

Missing parameters in bidAdjustment events

Description

Event bidAdjustment even has changed in prebid v0.26.0 - it lacks AdUnitCode, timeToRespond, requestTimestamp, responseTimestamp. Also, if bidResponse is empty or has an error, bidAdjustment doesn't have a CPM parameter.
@dbemiller dbemiller self-assigned this Jul 20, 2017
@dbemiller
Copy link
Contributor

dbemiller commented Jul 20, 2017 •
edited
Loading

Caused by some changes in #1277 and #1372. Didn't know anybody would be relying on this behavior. Will fix it shortly.

@alex-khar
Copy link

alex-khar commented Jul 20, 2017 •
edited
Loading

@dbemiller Our Prebid Analytics relies on this as it takes bids after adjustments from this event.

@dbemiller dbemiller mentioned this issue Jul 20, 2017
Merged
@GLStephen
Copy link
Collaborator

@dbemiller we use these parameters for PubWise analytics as well

@dbemiller
Copy link
Contributor

Fixed with the merge of #1399. Tenative plan is to release Prebid 0.26.1 with this fix (along with a few other things) on Monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbemiller dbemiller

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@GLStephen @kir-roxot @dbemiller @alex-khar