Fixing some recent bugs in addBidResponse #1372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… which adapters are doing this.
matthewlane
previously approved these changes
Jul 12, 2017
…e bid properties.
kitwestneat
reviewed
Jul 13, 2017
| @@ -108,11 +108,11 @@ exports.addBidResponse = function (adUnitCode, bid) { | |||
| } | |||
|
|
|||
| if (!adUnitCode) { | |||
| utils.logWarn(errorMessage('No adUnitCode was supplied to addBidResponse.')); | |||
There was a problem hiding this comment.
fwiw if you put the bid check before the adUnitCode, you could still use errorMessage here
There was a problem hiding this comment.
true, these checks really shouldn't be necessary anyway once we have a proper adapter validator in place.
mkendall07
approved these changes
Jul 13, 2017
This was referenced Jul 20, 2017
jbAdyoulike
pushed a commit
to jbAdyoulike/Prebid.js
that referenced
this pull request
Sep 21, 2017
* Added back the guard against undefined bids... for now. * Added back the guard to allow undefined bids, because we have no idea which adapters are doing this. * Made sure that the bid adjustment event fired before we use any of the bid properties.
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
* Added back the guard against undefined bids... for now. * Added back the guard to allow undefined bids, because we have no idea which adapters are doing this. * Made sure that the bid adjustment event fired before we use any of the bid properties.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Description of change
Fixing some regressions introduced in #1277
The old code allowed adapters to call
addBidResponsewithout supplying a bid. This permissibility may or may not be a good idea... but Implementing prebid-cache to support Video ads #1277 definitely isn't a good place to make that change. The(!bid)check is added back in here.The
bidAdustmentevent needs to be fired before thegetPriceBucketStringsgets called, because listeners for that event may mutate the bid's cpm.