Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading docs for downloading script #38

Closed
JuanCaicedo opened this issue Sep 2, 2015 · 2 comments
Closed

Misleading docs for downloading script #38

JuanCaicedo opened this issue Sep 2, 2015 · 2 comments

Comments

@JuanCaicedo
Copy link

From reading the docs, it seems you would be able to add that code into your page to load this library. However, https://cdn.site.com/prebid.js isn't a real url, so I guess that this code is more to suggest that if you have a CDN you're using, this is the pattern you could follow. I think this could be made much more explicit, I was definitely confused.

Also, is there a better way to load the most up to date version? Right now it seems like you have to manually download from here and host it yourself.

@ialex
Copy link
Contributor

ialex commented Sep 3, 2015

that's not a valid URL so you can download the library there or you can clone the repo and run gulp build to get the latest version it will be placed in Prebid.js/dist/build/ .

I just noticed the documentation is missing the call to pbjs.requestBids() is not especified in the publisher API but i can see it in the integration example. https://github.com/prebid/Prebid.js/blob/master/integrationExamples/gpt/pbjs_example_gpt.html

@mkendall07
Copy link
Member

Hi @JuanCaicedo,
Thanks for the note. I've clarified in the readme about the need to server prebid.js locally or on a CDN.

marian-r added a commit to aol/Prebid.js that referenced this issue Nov 2, 2016
…MP-73-unit-tests-false-timed-out-bids to release/1.4.1

* commit '8dabc4fbee8f523e08262b17b791b8f8b0ac1e55':
  Updated CHANGELOG
  Refactoring of unit tests for AOL analytics #2
  Minor refactoring of unit tests for AOL analytics
  Added more unit tests for AOL analytics
  Added unit tests for AOL analytics
  Refactoring of AOL analytics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants