Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rationalize KVP controls #8130

Closed
bretg opened this issue Mar 1, 2022 · 3 comments
Closed

Rationalize KVP controls #8130

bretg opened this issue Mar 1, 2022 · 3 comments

Comments

@bretg
Copy link
Collaborator

bretg commented Mar 1, 2022

Type of issue

breaking change

Description

Controlling PBJS ad server KVPs (aka "targeting") is quite complex. There are 12 different options publishers can define to refine what's sent. There are often edge-cases discovered where the interaction of several of these options don't work properly. This isn't surprising because we've never sat down to rationalize the whole mess of control options and how they're supposed to work together. Instead, people have just organically added yet another control randomly into the code to meet their specific use case.

The range of controls is documented at https://docs.prebid.org/features/adServerKvps.html

I've drafted a Prebid.js Ad Server KVP Control doc with a first cut at a coherent description of how the 12 controls work together. I'm certain that the current code doesn't work this way, and suspect that there will be some interesting debates about semantics.

I'd like to discuss as a community:

  1. Do people agree that the fringes of KVP control is a somewhat mysterious and idiosyncratic ritual?
  2. Are we willing to take a breaking change in this part of the system conform to some agreed-upon algorithm?
@bretg
Copy link
Collaborator Author

bretg commented Mar 8, 2022

Discussed in committee last week. We agreed that spending time in this area would be worthwhile, but it would more of a project for PBJS 8.0.

@dgirardi
Copy link
Collaborator

dgirardi commented Mar 14, 2022

Here's some related bug reports:

#6734
#8052

Their fix requires either modifying the effect of some of the current controls (which is a breaking change), or introducing more controls. The first route is obviously preferable, but are we OK with pushing it forward to 8.0? Should we consider a narrower redefinition of the "broken" controls for 7.0?

@patmmccann
Copy link
Collaborator

Work is not currently planned; people interested in this work are invited to express support and we may plan the work.

@patmmccann patmmccann closed this as not planned Won't fix, can't repro, duplicate, stale Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants