Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PBS KVPs for deals #2214

Closed
bretg opened this issue Apr 4, 2022 · 3 comments
Closed

PBS KVPs for deals #2214

bretg opened this issue Apr 4, 2022 · 3 comments
Assignees
Labels
PBS-Go Ready For Dev Feature specification is ready to be developed.

Comments

@bretg
Copy link
Contributor

bretg commented Apr 4, 2022

Supporting deal targeting is currently inconsistent across Prebid.js, SDK, and AMP.

I've added a note to https://docs.prebid.org/prebid-server/features/pbs-deals.html to describe the difference, but we should discuss whether a new PBS behavior is warranted. I think it may be. This is somewhat related to the PBJS issue prebid/Prebid.js#8130 , but I don't think we need major surgery on PBS.

Here are the current KVP controls in PBS:

  • ext.prebid.targeting:
    • includewinners - flag for whether seatbid.bid.ext.prebid.targeting is generated for the winning KVPs
    • includebidderkeys - flag for whether seatbid.bid.ext.prebid.targeting is generated for non-winning KVPs
    • includeformat - flag for whether seatbid.bid.ext.prebid.targeting.hb_format, hb_format_BIDDER are generated
    • preferdeals - flag for controlling PBS decisioning: by default, it's the highest bid that wins, but if this is true, the highest deal will beat out non-deals.
  • ext.prebid.adservertargeting: supports arbitrary KVPs https://docs.prebid.org/prebid-server/endpoints/openrtb2/pbs-endpoint-auction.html#custom-targeting-pbs-java-only

Proposed new KVP flag: alwaysincludedeals

PBS could support a ext.prebid.targeting.alwaysincludedeals that corresponds to the Prebid.js alwaysIncludeDeals flag.

If true, then PBS-core would generate seatbid.bid.ext.prebid.targeting.hb_*_BIDDER values for all bids with a dealid. This is independent of which other ext.prebid.targeting flags are present.

We would also update the pbsBidAdapter to set this flag to true when the corresponding PBJS flag is set.

@bretg
Copy link
Contributor Author

bretg commented Apr 15, 2022

approved in committee

@bretg bretg added the PBS-Go label May 20, 2022
@bretg
Copy link
Contributor Author

bretg commented May 20, 2022

Released with PBS-Java 1.89. Updated auction endpoint docs.

@SyntaxNode SyntaxNode added Ready For Dev Feature specification is ready to be developed. and removed feature request labels Sep 7, 2022
@bretg bretg removed the projectboard label Sep 8, 2022
@bretg bretg moved this from Triage to Ready for Dev in Prebid Server Prioritization Sep 23, 2022
@AlexBVolcy AlexBVolcy self-assigned this Jan 29, 2024
@SyntaxNode
Copy link
Contributor

Implemented in PBS-Go v2.8.0.

@github-project-automation github-project-automation bot moved this from Ready for Dev to Done in Prebid Server Prioritization Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PBS-Go Ready For Dev Feature specification is ready to be developed.
Projects
Status: Done
Development

No branches or pull requests

3 participants