-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't enforce mediaTypes for pbsBidAdapter #8291
Labels
Comments
1 task
dgirardi
added a commit
to dgirardi/Prebid.js
that referenced
this issue
May 2, 2022
This fixes adUnit mediaType validation to skip bids that will get routed to PBS (prebid#8291), and also removes overzealous mediaTytpe validation from the PBS adapter (by the time it gets there, adUnits have already been validated)
dgirardi
moved this from Ready for Dev
to PR submitted
in Prebid.js Tactical Issues table
May 2, 2022
Repository owner
moved this from PR submitted
to Done
in Prebid.js Tactical Issues table
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Type of issue
enhancement
Description
@patmmccann reported a scenario where the colossusssp doesn't match the server-side colossus adapter name. This would be fine except in when the mediaType is video, the pbsBidAdapter is removing the colossus bidder
In discussing this, we don't see why the PBS bid adapter should be filtering bidders for mediatypes. The server knows which bidders can support which mediatypes, and this can change any time.
We think it would be best for the pbsBidAdapter to not worry about enforcing this. In most cases, it doesn't save more than a few bytes in the outgoing request to let the server make the decision.
Steps to reproduce
Expected results
Call to PBS with colossus bidder
Actual results
Colossus is filtered because it's a video request and there's no client-side adapter declaring that it supports video
The text was updated successfully, but these errors were encountered: