Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't enforce mediaTypes for pbsBidAdapter #8291

Closed
bretg opened this issue Apr 15, 2022 · 1 comment · Fixed by #8357
Closed

Don't enforce mediaTypes for pbsBidAdapter #8291

bretg opened this issue Apr 15, 2022 · 1 comment · Fixed by #8357
Assignees

Comments

@bretg
Copy link
Collaborator

bretg commented Apr 15, 2022

Type of issue

enhancement

Description

@patmmccann reported a scenario where the colossusssp doesn't match the server-side colossus adapter name. This would be fine except in when the mediaType is video, the pbsBidAdapter is removing the colossus bidder

In discussing this, we don't see why the PBS bid adapter should be filtering bidders for mediatypes. The server knows which bidders can support which mediatypes, and this can change any time.

We think it would be best for the pbsBidAdapter to not worry about enforcing this. In most cases, it doesn't save more than a few bytes in the outgoing request to let the server make the decision.

Steps to reproduce

    var adUnits = [
           {
               code: 'test-div',
                mediaTypes: {
                    video: { ... }
               },
               bids: [{
                       bidder: 'colossus',
                       params: { ... }
               }]
          }
     ];

pbjs.setConfig({
        s2sConfig: {
                    accountId: '7780',
                    bidders: ['colossus'],
                    defaultVendor: 'rubicon'
        }
});

Expected results

Call to PBS with colossus bidder

Actual results

Colossus is filtered because it's a video request and there's no client-side adapter declaring that it supports video

@patmmccann
Copy link
Collaborator

patmmccann commented Apr 18, 2022

@mmoschovas @HuddledMasses fyi

@patmmccann patmmccann moved this from Triage to Ready for Dev in Prebid.js Tactical Issues table Apr 21, 2022
@dgirardi dgirardi self-assigned this May 2, 2022
dgirardi added a commit to dgirardi/Prebid.js that referenced this issue May 2, 2022
This fixes adUnit mediaType validation to skip bids that will get routed to PBS (prebid#8291), and also removes overzealous mediaTytpe validation from the PBS adapter (by the time it gets there, adUnits have already been validated)
@dgirardi dgirardi moved this from Ready for Dev to PR submitted in Prebid.js Tactical Issues table May 2, 2022
patmmccann pushed a commit that referenced this issue May 6, 2022
…8357)

This fixes adUnit mediaType validation to skip bids that will get routed to PBS (#8291), and also removes overzealous mediaTytpe validation from the PBS adapter (by the time it gets there, adUnits have already been validated)
Repository owner moved this from PR submitted to Done in Prebid.js Tactical Issues table May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

3 participants