-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does userID take too long to initialize by default? #8311
Comments
tagging #8295 as related |
@jdwieland8282 can you provide any feedback on this? We're interested your take, should auctiondelay 0 be faster than 1 |
Config/Setup around this is certainly not straight forward. I think the config option would be ideal (with perhaps some cleanup/refactor of what is there now to address the confusion). Would a |
The proposed requirement for the fix is that: auctionDelay: 1 should delay longer than auctionDelay: 0; and hence, that if someone explicitly sets 0, it will fire one ms before auctionDelay 1. If the value is not explicitly set, the default should be the existing behavior, initiating after the end of the first auction. |
#8311 (comment) yes intuitively it makes sense that the lower the integer the shorter amount of time need elapse before triggering the function. |
Tagging this as 7 to make sure we include in release notes, people should be well aware of behavior changes on this. Soliciting requirements feedback. |
It makes sense that But does it make sense that if your goal is to get userIDs sooner, you need to explicitly set Additionally, it turned out that in the original issue the OP was never interested in waiting for userID calls to complete, they just wanted to know the right time to get the cached IDs - now I'm wondering if changing the behavior of an |
@dgirardi I still feel it would be beneficial to make the getUserIdsAsync work better. We don't particularly need it anymore though, that's correct. |
It seems like a new configuration option is preferred to changing the behavior of auction delay zero; still assessing publisher demand. |
@dgirardi dumb q here: if a pub also has enableOverride set to true, does triggerUsersyncs fire the user module syncs or are those governed by the other params? |
enableOverride has no effect on userId, only on user syncs as defined by bid adapters. |
500 is a reasonable default; we can change it and move on. Arrived at by extensive yield testing. |
Type of issue
Question / feature request
Description
#8201 introduced
getUserIdsAsync()
, which gives publishers a way to wait for all userIDs to complete initialization.The time it takes for userID calls to complete is controlled through
syncDelay
and/orauctionDelay
configuration. By default, if neither is specified, userID modules will not start making their network calls until the first auction has completed.This results in
getUserIdsAsync()
taking a surprisingly long time, as the discussion in #5447 shows. It can be made quicker by settingauctionDelay: 1
(or greater), which does not seem very intuitive.Should we change the default behavior, or give a more explicit configuration option to start userID init early?
The text was updated successfully, but these errors were encountered: