Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prebid file not built properly #9037

Closed
AndBeyondMediaHB opened this issue Sep 26, 2022 · 6 comments
Closed

Prebid file not built properly #9037

AndBeyondMediaHB opened this issue Sep 26, 2022 · 6 comments
Assignees

Comments

@AndBeyondMediaHB
Copy link
Contributor

AndBeyondMediaHB commented Sep 26, 2022

Type of issue

bug

Description

When I try to download PrebidJs with the selected Compass adapter, I get an error:
{"error":"Prebid file not built properly","requestId":"e9179e40-85cb-4ba1-a0bd-4f03152ec8c0"}

Steps to reproduce

  1. Go to https://docs.prebid.org/download.html
  2. Select Compass adapter (biddercode - beyondmedia)
  3. Download Prebid.js
@dgirardi dgirardi self-assigned this Sep 26, 2022
@dgirardi
Copy link
Collaborator

dgirardi commented Sep 26, 2022

@AndBeyondMediaHB, what's the relationship between Compass and AndBeyondMedia?

There are two conflicting documentation files (which are used for the download page): both andBeyondMedia and compass declare a title of "Compass", so only one of them will show up - I'm not sure if the precedence is well defined. AndBeyondMedia also has an incorrect biddercode, it should be andBeyondMedia, this is what's causing the error.

@bretg
Copy link
Collaborator

bretg commented Sep 26, 2022

Docs issue prebid/prebid.github.io#4018
PBJS #9005

@AndBeyondMediaHB
Copy link
Contributor Author

@AndBeyondMediaHB, what's the relationship between Compass and AndBeyondMedia?

There are two conflicting documentation files (which are used for the download page): both andBeyondMedia and compass declare a title of "Compass", so only one of them will show up - I'm not sure if the precedence is well defined. AndBeyondMedia also has an incorrect biddercode, it should be andBeyondMedia, this is what's causing the error.

@dgirardi thanks for the answer. @bretg attached a pull request to change the title from Compass to AndBeyondMedia. Did I understand correctly that the biddercode must be the same as the adapter title in lower case? Or am I confusing with the adapter's .js file name?

@dgirardi
Copy link
Collaborator

dgirardi commented Sep 27, 2022

@AndBeyondMediaHB, for the website and download page, biddercode is just the file name minus BidAdapter. I think we recommend naming them the same as spec.code, hence the confusion.

@AndBeyondMediaHB
Copy link
Contributor Author

@dgirardi thanks, it's all clear now

@bretg
Copy link
Collaborator

bretg commented Oct 11, 2022

fixed in referenced PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants