Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: put gzip package size on download page #5402

Open
patmmccann opened this issue Jun 6, 2024 · 3 comments
Open

Proposal: put gzip package size on download page #5402

patmmccann opened this issue Jun 6, 2024 · 3 comments

Comments

@patmmccann
Copy link
Collaborator

I would really love it if the download page looked like this:

bidderx (13k)
biddery (2k)
bidderz (37k)
rtdmodulei (15k+)

where the + indicates they load external script according to https://github.com/prebid/Prebid.js/blob/03d7059502eed8d4cd7deefe457bd786c233aa3f/src/adloader.js#L6

@muuki88
Copy link
Contributor

muuki88 commented Jun 13, 2024

This would indeed be a nice thing to have. Question is, how to determine the size

  • minified or not?
  • which browser target? es5,6, 2020?
  • are polyfills required?
  • does it import stuff from prebid that would have otherwise not been used?

@patmmccann
Copy link
Collaborator Author

I'm not sure, definitely minified. For the target, whatever the precompiled one in the download page is using.

@dgirardi
Copy link
Contributor

Could we use this as an opportunity to overhaul the download page? To avoid reoccurring issues like prebid/Prebid.js#11811 or prebid/Prebid.js#9037. Instead of generating a list of modules from docs, it should IMO display the modules available for the selected version, and show a placeholder / warning if no docs can be found for any given module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants