Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Atomx support #1056

Merged
merged 1 commit into from
Mar 30, 2017
Merged

Add Atomx support #1056

merged 1 commit into from
Mar 30, 2017

Conversation

erikdubbelboer
Copy link
Contributor

Type of change

  • New bidder adapter

Description of change

Add Atomx bidder adapter.

  • test parameters for validating bids:
{
  bidder: 'atomx',
  params: {
    id: 2
  }
}

@aneuway2
Copy link
Contributor

Hey @erikdubbelboer , just a heads up that you may want to also submit a PR to have your adaptor documented on prebid.org :-)

https://github.com/prebid/prebid.github.io/tree/master/dev-docs/bidders

@erikdubbelboer
Copy link
Contributor Author

@aneuway2 I already had this ready but was waiting for this to be merged. Created the pull request now anyways: prebid/prebid.github.io#201

jaiminpanchal27
jaiminpanchal27 requested changes Mar 24, 2017
View reviewed changes
Copy link
Collaborator

@jaiminpanchal27 jaiminpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am getting the bid back but it prints raw javascript inside div.
Also check the comments. Thanks

src/adapters/atomx.js Outdated
utils.logError(_error);
}
if (bid.cpm > 0) {
bidObject = bidfactory.createBid(1);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pass bidrequest object as second argument to match bid request/response pair

src/adapters/atomx.js Outdated
bidObject.width = bid.width;
bidObject.height = bid.height;
} else {
bidObject = bidfactory.createBid(2);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pass bidrequest object as second argument to match bid request/response pair

@erikdubbelboer
Copy link
Contributor Author

@jaiminpanchal27 sorry, I should have paid better attention. The bugs have been fixed.

@jaiminpanchal27
Copy link
Collaborator

@erikdubbelboer I have created a test page and the creatives loaded on the page always navigates the parent page.
Is the external script loaded by adapter responsible for this behavior ?
Please update with good creative.

@erikdubbelboer
Copy link
Contributor Author

@jaiminpanchal27 my mistake, I should have given you a proper ID. Try:

{
  bidder: 'atomx',
  params: { id: 7395 }
}

@mkendall07
Copy link
Member

LGTM.

@jaiminpanchal27 jaiminpanchal27 merged commit 938d00d into prebid:master Mar 30, 2017
@jaiminpanchal27
Copy link
Collaborator

This is merged into master. Please submit a PR to the docs repo to add a file for your adapter to the bidders directory so your adapter's params will appear on the bidders page. Thank you for contributing

@erikdubbelboer
Copy link
Contributor Author

@jaiminpanchal27 See prebid/prebid.github.io#201

@erikdubbelboer
Copy link
Contributor Author

@mkendall07 Is there any reason why Atomx isn't in the "New adapter" list here but instead separately?

@mkendall07
Copy link
Member

@erikdubbelboer
Looks like it was just missed. Fixed it now. Thanks

outoftime added a commit to Genius/Prebid.js that referenced this pull request Apr 19, 2017
@outoftime
Merge branch 'master' of https://github.com/prebid/Prebid.js into pre…
b930704 
…built

* 'master' of https://github.com/prebid/Prebid.js: (38 commits)
  Add optional domain parameter to AdButler adapter (prebid#1078)
  Send transactionID to Criteo Services (prebid#1113)
  Fix `buildMasterVideoTagFromAdserverTag()` not selecting winning bid (prebid#1106)
  Remove placement size selection and filtering (prebid#1107)
  revert `srcdoc` change (prebid#1130)
  Add new Adapter- Beachfront Media (prebid#1062)
  Fixes SpringServe adapter (prebid#1101)
  Update Widespace request param (prebid#1098)
  - New Adapter: Innity (prebid#1074)
  Update Roxot prebid analytic adapter (prebid#1034)
  Yarn Package Manager (prebid#1109)
  allow writing into current document if prebid is loaded inside an iframe (prebid#1066)
  Adapter bug fix (prebid#1096)
  fix typo
  added pr review process and governance model (prebid#1103)
  added support for sampling in ga and base adapter, fixed up some tests (prebid#1011)
  Add Inneractive adapter (prebid#1048)
  Add alias freewheel-ssp to stickyadstv bidder adapter  (prebid#1043)
  Add Facebook Audience Network adapter (prebid#1068)
  Add Atomx support (prebid#1056)
  ...
vzhukovsky added a commit to aol/Prebid.js that referenced this pull request May 19, 2017
@vzhukovsky
Merge pull request prebid#90 in AOLP_ADS_JS/prebid.js from release/1.…
8b44d83 
…19.0 to aolgithub-master

* commit '5109273bd4317535b23e26ff609345101a3d038d': (49 commits)
  Disable unit tests that fails on PhantomJs.
  Fixed unit tests for adapter loader.
  Changed way of including analytic adapters.
  Added adapters in aolPartnersIds.json.
  Added changelog entry.
  Replace removed utils.extend functionality by object.assign.
  Add Inneractive adapter (prebid#1048)
  Add alias freewheel-ssp to stickyadstv bidder adapter  (prebid#1043)
  Add Facebook Audience Network adapter (prebid#1068)
  Add Atomx support (prebid#1056)
  Updated rubicon video bid endpoint in source and test files (prebid#1097)
  Pass through params to server (prebid#1084)
  Reset the list of slots to be requested between each action for pubmatic (prebid#1079)
  Support for downloading Analytics Adapters via http://prebid.org/download.html (prebid#1021)
  update PR template to include link to dev docs page (prebid#1075)
  Prebid 0.21.0
  Lifestreet adapter: ignore unnecessary events from creative. (prebid#1054)
  Video header bidding support to RhythmOne bidder adapter (prebid#1052)
  Add rubicon targeting to rubicon bid responses for bidderSettings use (prebid#1045)
  Fix adapter getSize (prebid#1064)
  ...
vzhukovsky added a commit to aol/Prebid.js that referenced this pull request May 22, 2017
@vzhukovsky
Merge pull request prebid#91 in AOLP_ADS_JS/prebid.js from release/1.…
ab3f32e 
…19.0 to master

* commit '5109273bd4317535b23e26ff609345101a3d038d': (49 commits)
  Disable unit tests that fails on PhantomJs.
  Fixed unit tests for adapter loader.
  Changed way of including analytic adapters.
  Added adapters in aolPartnersIds.json.
  Added changelog entry.
  Replace removed utils.extend functionality by object.assign.
  Add Inneractive adapter (prebid#1048)
  Add alias freewheel-ssp to stickyadstv bidder adapter  (prebid#1043)
  Add Facebook Audience Network adapter (prebid#1068)
  Add Atomx support (prebid#1056)
  Updated rubicon video bid endpoint in source and test files (prebid#1097)
  Pass through params to server (prebid#1084)
  Reset the list of slots to be requested between each action for pubmatic (prebid#1079)
  Support for downloading Analytics Adapters via http://prebid.org/download.html (prebid#1021)
  update PR template to include link to dev docs page (prebid#1075)
  Prebid 0.21.0
  Lifestreet adapter: ignore unnecessary events from creative. (prebid#1054)
  Video header bidding support to RhythmOne bidder adapter (prebid#1052)
  Add rubicon targeting to rubicon bid responses for bidderSettings use (prebid#1045)
  Fix adapter getSize (prebid#1064)
  ...
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
@erikdubbelboer @dluxemburg
Add Atomx support (prebid#1056)
5481c26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaiminpanchal27 jaiminpanchal27 jaiminpanchal27 approved these changes

Assignees

@jaiminpanchal27 jaiminpanchal27

Labels
LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@erikdubbelboer @aneuway2 @jaiminpanchal27 @mkendall07 @matthewlane