Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MediaImpact Bid Adapter : add custom size parameter to request #11254

Merged
merged 5 commits into from
Apr 4, 2024

Conversation

nalexand
Copy link
Contributor

@nalexand nalexand commented Mar 25, 2024

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Other information

@ChrisHuie ChrisHuie changed the title Add custom size parameter to request MediaImpact Bid Adapter : add custom size parameter to request Mar 25, 2024
@JulieLorin
Copy link
Collaborator

This change affects bidder documentation on docs.prebid.org (a new parameter is added), there should be a linked pull request to update mediaimpact doc

@nalexand
Copy link
Contributor Author

nalexand commented Apr 1, 2024

Copy link
Collaborator

@JulieLorin JulieLorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChrisHuie ChrisHuie merged commit d1d1564 into prebid:master Apr 4, 2024
4 checks passed
mefjush pushed a commit to adhese/Prebid.js that referenced this pull request Apr 8, 2024
…d#11254)

* Add mediaimpact bid adapter

* Add mediaimpact bid adapter tests

* Add custom sizes

---------

Co-authored-by: koshe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants