-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AzerionEdge RTD Module: Compatibility with GDPR/USP Privacy Modules #11775
Merged
Merged
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
c629d4c
Azerion Edge RTD Module: Initial release
garciapuig 09c1cbc
Azerion Edge RTD Module: Initial release. Typo
garciapuig 6c7dba5
Merge branch 'prebid:master' into master
garciapuig 1ea3284
Merge branch 'prebid:master' into master
gguridi 732cbc0
AzerionEdge RTD Module: Documentation: Required parameters
garciapuig 98762e9
Merge branch 'prebid:master' into master
gguridi 57dfa79
Merge branch 'prebid:master' into master
gguridi fb704f3
AzerionEdge RTD Module: Compatible with GDPR/USP Privacy Modules (#14)
garciapuig b5db3a1
Merge commit 'ac95edbaec2eb9361bb0e1a1ec8a8ffd45798056'
garciapuig 322be6d
AzerionEdgeRTDModule: Passing the consent to the script execution (#17)
garciapuig File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this something the
tcfConsentManagement
module should handle?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we understood the functionality of the
consentManagement
module correctly. Please let me know if anything that I'm saying is incorrect.The consentManagment module is used to fetch, decode and pass the user consent to bid adapter, RTD modules, etc. The publisher uses this module to configure the integration with its CMP. It also allows adding some rules to automatically enforce GDPR based on their GVL_ID through the gdprEnforcement module. Like the one shown here as Sirdata's example:
But if we want to automatically check the consent given for our module from inside our RTD module, without the publisher having to configure that, we can't use the
consentManagement
module. We've seen other modules doing the checks manually like in our case. For instance sirdata.We are not sure if there's a better way of doing this through any helpers, or exported functions from consentManagement/gdprEnforcement modules. The closest we could find was the method hasPurpose1Consent but it only checks for one purpose and we need to check five.
Any insight or suggestion about how to better approach this would be greatly appreciated.