Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dynamic bidfloor parameter to Smart Adserver Adapter #1194

Merged
merged 12 commits into from
May 17, 2017
Merged

Add dynamic bidfloor parameter to Smart Adserver Adapter #1194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
da8c0ed
Smart AdServer adapter
adesmoules Dec 5, 2016
2f2e69a
Merge remote-tracking branch 'refs/remotes/prebid/master'
adesmoules Dec 13, 2016
3251526
fix not supported method
adesmoules Dec 15, 2016
5701516
Issue with optional parameter
adesmoules Dec 26, 2016
72ceff9
Merge branch 'master' into master
adesmoules Dec 27, 2016
c72c4fe
Merge remote-tracking branch 'refs/remotes/prebid/master'
adesmoules Jan 13, 2017
63b89d1
Merge remote-tracking branch 'refs/remotes/prebid/master'
adesmoules Feb 1, 2017
cf4e8a5
Merge remote-tracking branch 'refs/remotes/prebid/master'
adesmoules Feb 9, 2017
e92d199
Merge remote-tracking branch 'refs/remotes/prebid/master'
Mar 6, 2017
d9e2b72
Merge branch 'master' of https://github.com/prebid/Prebid.js
Apr 5, 2017
81edbe5
Merge remote-tracking branch 'refs/remotes/prebid/master'
May 11, 2017
cf5674c
Add dynamic bidfloor option in the SmartAdServer prebid call.
May 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/adapters/smartadserver.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ var SmartAdServer = function SmartAdServer() {
"pgid": bid.params.pageId,
"fmtid": bid.params.formatId,
"ccy": bid.params.currency || "USD",
"bidfloor": bid.params.bidfloor || 0.0,
"tgt": encodeURIComponent(bid.params.target || ''),
"tag": bid.placementCode,
"sizes": bid.sizes.map(size => size[0] + "x" + size[1]).join(","),
Expand Down
4 changes: 3 additions & 1 deletion test/spec/adapters/smartadserver_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ describe("smartadserver adapter tests", function () {
pageId: "5678",
formatId: "90",
target: "test=prebid",
currency: "EUR"
currency: "EUR",
bidfloor: 0.420
},
requestId: "efgh5678",
placementCode: "sas_42"
Expand Down Expand Up @@ -78,6 +79,7 @@ describe("smartadserver adapter tests", function () {
expect(parsedBidUrlQueryString).to.have.property("fmtid").and.to.equal("90");
expect(parsedBidUrlQueryString).to.have.property("tgt").and.to.equal("test=prebid");
expect(parsedBidUrlQueryString).to.have.property("ccy").and.to.equal("EUR");
expect(parsedBidUrlQueryString).to.have.property("bidfloor").and.to.equal("0.42");
expect(parsedBidUrlQueryString).to.have.property("tag").and.to.equal("sas_42");
expect(parsedBidUrlQueryString).to.have.property("sizes").and.to.equal("300x250,300x200");
expect(parsedBidUrlQueryString).to.have.property("async").and.to.equal("1");
Expand Down