Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map sponsor request param to endpoint param #1219

Merged
merged 1 commit into from
May 24, 2017
Merged

Map sponsor request param to endpoint param #1219

merged 1 commit into from
May 24, 2017

Conversation

matthewlane
Copy link
Collaborator

@matthewlane matthewlane commented May 22, 2017 •
edited
Loading

Type of change

  • Bugfix

Description of change

This updates appnexusAst to map the sponsoredBy native parameter to the parameter the appnexusAst endpoint expects for that field. Ad units defined with

nativeParams: {
  sponsoredBy: {required: true}
}

will now properly request that field for appnexusAst

mkendall07
mkendall07 approved these changes May 23, 2017
View reviewed changes
Copy link
Member

@mkendall07 mkendall07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@protonate protonate merged commit b97baca into master May 24, 2017
@matthewlane matthewlane deleted the bugfix/sponsor-field branch May 25, 2017 04:07
vzhukovsky added a commit to aol/Prebid.js that referenced this pull request Jul 17, 2017
@vzhukovsky
Merge pull request prebid#109 in AOLP_ADS_JS/prebid.js from release/1…
ea3bf0f 
….23.0 to aolgithub-master

* commit '136fc37637749a764070c35c03e7e87a5c157947': (33 commits)
  Added changelog entry.
  Implemented passing key values feature.
  Update code to ESlint rules.
  Prebid 0.24.1 Release
  tests: drop ie9 browserstack test
  Audience Network: separate size from format (prebid#1218)
  Bugfix/target filtering api fix (prebid#1220)
  Map sponsor request param to endpoint param (prebid#1219)
  Increment pre version
  Probed 0.24.0 Release
  Beachfront adapter - add ad unit size (prebid#1183)
  Thoughtleadr adapter - fix postMessage (prebid#1207)
  When prebid server issues a no-bid response, call addBidResponse for every adUnit requested (prebid#1204)
  Improvement/timeout xhr (prebid#1172)
  Add native support (prebid#1072)
  Improvement/alias queue (prebid#1156)
  Updated documentaion (prebid#1160)
  Improvement/prebid iframes amp pages (prebid#1119)
  Fixes prebid#1114 possible xss issue (prebid#1186)
  Allowed setTargetingForGPTAsync() to target specific ad unit codes. (prebid#1158)
  ...
jbAdyoulike pushed a commit to jbAdyoulike/Prebid.js that referenced this pull request Sep 21, 2017
@matthewlane @jbAdyoulike
Map sponsor request param to endpoint param (prebid#1219)
3efd3e4
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
@matthewlane @dluxemburg
Map sponsor request param to endpoint param (prebid#1219)
d33c705
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@protonate protonate protonate approved these changes

@mkendall07 mkendall07 mkendall07 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewlane @mkendall07 @protonate