Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carambola Adapter #1221

Merged
merged 11 commits into from
Jun 13, 2017
Merged

Carambola Adapter #1221

merged 11 commits into from
Jun 13, 2017

Conversation

LiranMotola
Copy link
Contributor

@LiranMotola LiranMotola commented May 23, 2017

Type of change

  • New bidder adapter

Description of change

New adapter submitted

  • test parameters for validating bids
{
    bidder: 'carambola',
    adId: "2e3daacdeed03d",
    requestId: 'c9ad932a-41d9-4821-b6dc-0c8146029faf',
    adUnitCode:"cbola_prebid_code_97",
    token:"CGYCLyIy",
    pageViewId:"22478638",
    params: {
      pid: 'hbtest',
      did: 110000,
      wid: 0
    }
  }

@LiranMotola LiranMotola reopened this May 23, 2017
@protonate protonate self-assigned this May 26, 2017
@protonate protonate added this to the Prebid 0.25.0 milestone Jun 2, 2017
@protonate
Copy link
Collaborator

Thanks for the contribution, I'm unsure about the test params, these appear to be "bid-specific" rather than configuration for your adapter:

    adId: "2e3daacdeed03d",
    requestId: 'c9ad932a-41d9-4821-b6dc-0c8146029faf',
    adUnitCode:"cbola_prebid_code_97",
    token:"CGYCLyIy",
    pageViewId:"22478638",

Copy link
Collaborator

@protonate protonate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not getting bids back currently with the params provided.

// the responses of the bid requests
ajax(cbolaHbApiUrl + _jsonToQueryString(tempParams), response => {
// no response
if (!response || response.cpm <= 0) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

response here is still a string and needs to be JSON.parsed before you can access properties e.g. response.cpm

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. indeed there was an error. fixed now.

fixed: response is still a string and needs to be JSON.parsed (#1221)
@protonate
Copy link
Collaborator

Hi @LiranMotola I'm still not getting bids back and have questions about the need for the bidder settings config that is "bid specific".

@LiranMotola
Copy link
Contributor Author

LiranMotola commented Jun 11, 2017

Hi @protonate , the following params will get you a valid bid response now:
params: {pid: 'hbtest', did: 112591, wid: 0 }
Regarding the "DEFAULT_BIDDER_REQUEST" object which is a "bid-specific", those params are dynamically build using the carambola adapter. I have hard coded them so it will be easier to set a request to the server.
Thanks!

@protonate
Copy link
Collaborator

Thanks, confirmed bids back, reviewed.

@protonate protonate merged commit 961c826 into prebid:master Jun 13, 2017
vzhukovsky added a commit to aol/Prebid.js that referenced this pull request Sep 6, 2017
….24.0 to aolgithub-master

* commit '7a81386579a3c129617323ef32e1c8be0897c3c7': (31 commits)
  Added changelog entry.
  Added records in aolPartnersIds.json.
  Prebid 0.25.0 Release
  Added Unruly adapter (prebid#1264)
  Fixing Adyoulike adapter for Safari iOS7 (prebid#1296)
  hide overflow to prevent scrolling (prebid#1294)
  fix protocol detection in iframe (prebid#1293)
  Add eplanning adapter (prebid#1245)
  Use Renderer command queue to render outstream (prebid#1283)
  Generate no-bid response for ech bid request not matched by a bid (prebid#1216)
  New Cox adapter (prebid#1228)
  Carambola Adapter (prebid#1221)
  Pass through transactionId and set fd=1 (prebid#1259)
  Integration test page for adapters (prebid#1182)
  Getting DigiTrustID in GumGum adapter (prebid#1256)
  Trion adapter (prebid#1254)
  use request bidder code as default bidderCode for createBid (prebid#1235)
  Add drop pixels once feature to AOL Adapter (prebid#1224)
  Rubicon Adapter - Adding 320x150 (prebid#1279)
  Prevent 'about:' protocol in _publisherTagUrl (prebid#1170)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants