-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Carambola Adapter #1221
Carambola Adapter #1221
Conversation
Carambola.js adapters Carambola_spec.js test
carambola_spec.js semantic changes
some small changes to improve code readability
Carambola Adapter
Thanks for the contribution, I'm unsure about the test params, these appear to be "bid-specific" rather than configuration for your adapter:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not getting bids back currently with the params provided.
// the responses of the bid requests | ||
ajax(cbolaHbApiUrl + _jsonToQueryString(tempParams), response => { | ||
// no response | ||
if (!response || response.cpm <= 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
response
here is still a string and needs to be JSON.parse
d before you can access properties e.g. response.cpm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. indeed there was an error. fixed now.
fixed: response is still a string and needs to be JSON.parsed (#1221)
Hi @LiranMotola I'm still not getting bids back and have questions about the need for the bidder settings config that is "bid specific". |
Hi @protonate , the following params will get you a valid bid response now: |
Thanks, confirmed bids back, reviewed. |
….24.0 to aolgithub-master * commit '7a81386579a3c129617323ef32e1c8be0897c3c7': (31 commits) Added changelog entry. Added records in aolPartnersIds.json. Prebid 0.25.0 Release Added Unruly adapter (prebid#1264) Fixing Adyoulike adapter for Safari iOS7 (prebid#1296) hide overflow to prevent scrolling (prebid#1294) fix protocol detection in iframe (prebid#1293) Add eplanning adapter (prebid#1245) Use Renderer command queue to render outstream (prebid#1283) Generate no-bid response for ech bid request not matched by a bid (prebid#1216) New Cox adapter (prebid#1228) Carambola Adapter (prebid#1221) Pass through transactionId and set fd=1 (prebid#1259) Integration test page for adapters (prebid#1182) Getting DigiTrustID in GumGum adapter (prebid#1256) Trion adapter (prebid#1254) use request bidder code as default bidderCode for createBid (prebid#1235) Add drop pixels once feature to AOL Adapter (prebid#1224) Rubicon Adapter - Adding 320x150 (prebid#1279) Prevent 'about:' protocol in _publisherTagUrl (prebid#1170) ...
Type of change
Description of change
New adapter submitted