Adkernel Bid Adapter: Remove FelixAds #12233
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wait for the final decision, we are trying to get a response from FelixAds partner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE I am NOT the maintainer for AdKernel nor a representative of FelixAds, just noticed a potential duplicated alias while analyzing the codebase. Requires approval from @felixads @SmartHubSolutions @ckbo3hrk
Type of change
Description of change
Remove possibly incorrect alias (currently felixads is aliased to both adkernel and smarthub).
What is the expected behavior of two bid adapters listing the same code as an alias? Is it considered a bug, or should both bid adapters send requests?
Other information
Reason I believe this alias may no longer be valid is since #12072, and docs for FelixAds were updated to smarthub bid params from adkernel's in prebid/prebid.github.io#5521