51Degrees RTD submodule: add crossorigin attribute to script tag
#12329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
related: #8500 |
|
I don't think we can change the default, as some scripts may depend on headers included. |
patmmccann
approved these changes
Oct 21, 2024
pdamoc
pushed a commit
to missena-corp/Prebid.js
that referenced
this pull request
Oct 22, 2024
…rebid#12329) Co-authored-by: Bohdan V <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
crossorigin="anonymous"attribute to address an issue with Chromium making two separate connections on different sockets due to CORS restrictions.This is happening because Chromium assigns different privacy modes (
pm=disabledfor the script andpm=enabledfor the API call). When the privacy mode isenabledfor one request anddisabledfor another, Chromium opens separate connections on different sockets.By adding the
crossorigin="anonymous"attribute, the script request is forced intopm=enabledmode, ensuring that both the script and subsequent API calls reuse the same socket. Using the same socket reduces the elapsed time to complete processing.A big thanks to @BohdanVV for working on this.