Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docereeAdManager Bid Adapter : updated bid adapter #12333

Merged
merged 32 commits into from
Oct 22, 2024

Conversation

Doceree-techStack
Copy link
Contributor

Type of change

  • Bugfix

  • [] Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Added support for accepting publisher page url

Other information

Copy link

Tread carefully! This PR adds 1 linter error (possibly disabled through directives):

  • modules/docereeAdManagerBidAdapter.js (+1 error)

@Doceree-techStack
Copy link
Contributor Author

Please review!

@Doceree-techStack
Copy link
Contributor Author

Could you clarify why there's no review on this pull request yet?

@ChrisHuie ChrisHuie changed the title docereeAdManager Bid Adapter : Updated bid adapter docereeAdManager Bid Adapter : updated bid adapter Oct 21, 2024
@ChrisHuie
Copy link
Collaborator

Could you clarify why there's no review on this pull request yet?

Almost all the reviewers of prs in Prebid are volunteers from supporting companies and Prebid hosted a conference on Tuesday so most folks have been away from the repo last week.

@Doceree-techStack
Copy link
Contributor Author

Added test cases, please review!

@ChrisHuie ChrisHuie self-assigned this Oct 22, 2024
@ChrisHuie ChrisHuie merged commit c90f9b3 into prebid:master Oct 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants