Xhb Adapter: adding alias support #1290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaiminpanchal27
requested changes
Jun 27, 2017
There was a problem hiding this comment.
@daniel-hoffmann
Modules have been introduces in Prebid with this PR #1177
Your adapter is already converted to new style
https://github.com/prebid/Prebid.js/blob/master/modules/xhbBidAdapter.js
So take latest copy of master and merge changes here.
|
@jaiminpanchal27 Can you please check if the most recent commit is okay? Thanks! :) |
jaiminpanchal27
previously approved these changes
Jul 5, 2017
mkendall07
requested changes
Jul 11, 2017
modules/xhbBidAdapter.js
Outdated
| }; | ||
| bidmanager.registerDefaultBidderSetting('xhb', _defaultBidderSettings); |
There was a problem hiding this comment.
It was originally, yes - but on second though, it probably is better to keep it in for the time being, so I added it in again.
| let adId = jptResponseObj.result.creative_id; | ||
| bid = bidfactory.createBid(CONSTANTS.STATUS.GOOD, bidObj); |
There was a problem hiding this comment.
Please keep the constant value here
modules/xhbBidAdapter.js
Outdated
| bid = bidfactory.createBid(2); | ||
| // no response data | ||
| // indicate that there is no bid for this placement | ||
| bid = bidfactory.createBid(2, bidObj); |
|
@daniel-hoffmann |
mkendall07
approved these changes
Jul 13, 2017
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Changed Xhb Adapter to allow aliasing
Let me know if any changes need to be made.