Empty bidRequests in AST adapter each time new auction begins #1305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therefore bidRequests must be emptied each time new auction begins Fixes prebid#1304
mkendall07
reviewed
Jun 20, 2017
| const placement = bidRequests[bid.adId].placementCode; | ||
| bidmanager.addBidResponse(placement, bid); | ||
|
|
||
| if (bid.adId in bidRequests) { |
There was a problem hiding this comment.
is there ever a reason the adId isn't in bidRequests ?
There was a problem hiding this comment.
Yes, if the response from the 1st auction is extremely slow and arrives after the 2nd auction has already started and bidRequests list has been emptied, then bidRequests will have adId's from the second auction, and adId from the first auction will have no corresponding entry.
There was a problem hiding this comment.
yeah that makes sense. In that case we are OK to throw away the bid response so this is ok.
mkendall07
approved these changes
Jun 21, 2017
Yann-Pravo
pushed a commit
to Yann-Pravo/Prebid.js
that referenced
this pull request
Jul 6, 2017
…#1305) When error occurs adapter issues response for each bid in `bidRequests` therefore bidRequests must be emptied each time new auction begins Fixes prebid#1304
jbAdyoulike
pushed a commit
to jbAdyoulike/Prebid.js
that referenced
this pull request
Sep 21, 2017
…#1305) When error occurs adapter issues response for each bid in `bidRequests` therefore bidRequests must be emptied each time new auction begins Fixes prebid#1304
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
…#1305) When error occurs adapter issues response for each bid in `bidRequests` therefore bidRequests must be emptied each time new auction begins Fixes prebid#1304
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When error occurs adapter issues response for each bid in
bidRequeststherefore bidRequests must be emptied each time new auction begins
Fixes #1304
Type of change
Description of change
Empty bidRequests each time new auction begins, because when an error occurs adapter issues a response for each request in this array.
Other information
#1304