Kargo adapter

[samuelhorwitz]

Type of change

• Bugfix
• Feature
• New bidder adapter
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Other

Description of change

Adding an adapter for Kargo Global, Inc..

• test parameters for validating bids

{
  bidder: 'kargo',
  params: {
    placementId: '_lak5xuxuRo'
  }
},
{
  bidder: 'kargo',
  params: {
    placementId: '_m1Xt2E5dez'
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

• contact email of the adapter’s maintainer: [email protected]
• official adapter submission

Other information

[samuelhorwitz]

@protonate sorry if you are not the right person to ask here, but the Travis build is failing due to a Criteo test that fails (I haven't touched any of that code) and it also looks like the test suite bails before even finishing all the tests. I'm not sure how to resolve this but I don't believe it's our code that is triggering the Travis failure.
https://travis-ci.org/prebid/Prebid.js/builds/245448854#L1026

[dbemiller]

@samuelhorwitz No worries, you're absolutely right :).

Criteo fixed the issue in #1308. If you pull in the most recent changes those failures should go away.

[samuelhorwitz]

Cool thanks! Rebased everything, it's still bailing out at test 443 which might be our end, I will re-test locally again.

[samuelhorwitz]

Fixed up my tests and it appears that everything runs all the way through now.

[samuelhorwitz]

@dbemiller @protonate I have updated this PR to reflect all the re-organization of code on master and all the tests are passing with good (above 80%) coverage results. Is there anything else I need to do for this PR?

[dbemiller]

@samuelhorwitz No promises either way yet :).

Time to review this isn't scheduled in our current sprint... so I wouldn't expect anyone to look at it until at least next week. We'll let you know, though.

[samuelhorwitz]

Cool, sounds good!

[samuelhorwitz]

Hey guys does this week seem likely for a review?

[dbemiller]

Looks great to me. Very nice code... you should be proud :).

FYI: You might want to update the docs explaining your bidder params too.

[samuelhorwitz]

Thanks! I have a documentation update here

prebid/prebid.github.io#274