Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement/rad 1689 s2s drop empty bid #1330

Merged
merged 4 commits into from
Jun 30, 2017

Conversation

mkendall07
Copy link
Member

Type of change

  • Bugfix

Description of change

Don't send empty bids to prebid server.

Other information

@jaiminpanchal27 @matthewlane for review.

Copy link
Collaborator

@matthewlane matthewlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkendall07 mkendall07 merged commit 27fe1c2 into master Jun 30, 2017
@mkendall07 mkendall07 deleted the improvement/RAD-1689_s2s_drop_empty_bid branch June 30, 2017 16:48
Yann-Pravo pushed a commit to Yann-Pravo/Prebid.js that referenced this pull request Jul 6, 2017
* fix sending empty bids + tests

* add unit tests

* Include `src` on bidRequest object.
jbAdyoulike pushed a commit to jbAdyoulike/Prebid.js that referenced this pull request Sep 21, 2017
* fix sending empty bids + tests

* add unit tests

* Include `src` on bidRequest object.
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
* fix sending empty bids + tests

* add unit tests

* Include `src` on bidRequest object.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants